From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D49CC6FD1D for ; Mon, 27 Mar 2023 23:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjC0XJC (ORCPT ); Mon, 27 Mar 2023 19:09:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjC0XJB (ORCPT ); Mon, 27 Mar 2023 19:09:01 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 712D3213B; Mon, 27 Mar 2023 16:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oMDBWqWOlIU0sHD7bRFINkPbOz4tKP/jx+uoy8N2eAk=; b=jq9AhNHYbXWbeJb64OED8KLPrC CH3w8f30Va2EwWmHyytVUhjFeQwtwxGhO2OTQCWhnKTB5oYVu9fnp3+shk0u/Xxc5kyYcYIdgq/fI OcwtxGs7LV71vbhmZVqEaNOhnFlUVRZqCCJUG82hKMmVjrsExdV4z3IWMOnpcqDCtPOdTAmdYSg3H NdH6CaS6dIpKihvKhO2n8uZecFGV93QVFqXRcpWjSkQ6ci/Qhnml2b9ZXmhxKOMTXVxugedYVJy+a tfo4pi7gWtvbpkhJDEiP3htz1hltRoGMj220K07jyxRftTU+B6i+CvnEsD0Rnqc28qaYaGPVpCBXe Kc+iJ3cg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pgvxM-00CdF7-2N; Mon, 27 Mar 2023 23:08:52 +0000 Date: Mon, 27 Mar 2023 16:08:52 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: axboe@kernel.dk, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: annotate bdev_disk_changed() deprecation with a symbol namespace Message-ID: References: <20230327184410.2881786-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Mar 27, 2023 at 04:02:02PM -0700, Luis Chamberlain wrote: > On Mon, Mar 27, 2023 at 03:16:39PM -0700, Christoph Hellwig wrote: > > What I'd really want is something like an > > > > EXPORT_SYMBOL_FOR(bdev_disk_changed, loop, CONFIG_BLK_DEV_LOOP); > > EXPORT_SYMBOL_FOR(bdev_disk_changed, dasd_kmod, CONFIG_DASD); > > > > Which ensures that the symbol lookup only succeeds for loop.ko and > > dasd_kmod.ko, and that the export only happens if the relevant > > symbols are set. > > I think that could be done, sure. BTW is anyone aware of similar exports which are stuck in this way? Luis