From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BE7C6FD18 for ; Tue, 28 Mar 2023 18:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbjC1Su0 (ORCPT ); Tue, 28 Mar 2023 14:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjC1SuZ (ORCPT ); Tue, 28 Mar 2023 14:50:25 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68896212F for ; Tue, 28 Mar 2023 11:50:24 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id i5so53908656eda.0 for ; Tue, 28 Mar 2023 11:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680029423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iZSVb7anGXXb5zwCrWYt7xgUpKRegbsbYrM5HxY90BU=; b=1QR4XjLLHLwM3Zmsgaw3zWAa78I3csLORy/e4VsQEXzXCtITlQVpm9CWPmkA6lEcIE l9vmq5KaRQWWkY58REzTUL7Y/u5ZvmJs1xya/EdeYG29I/YbohF5pbuCFsfRBDGYlfpa p4+KCJ7vkwLoJ30cObjArAxVzTagZEWVhWKhny11ej+ktXnisgks1Ea5bw54UXSAFUJP EZNJCkG8Zn+gP472ONOhnUlgPe0T6dvbJ34PIKUqkH13xcjMBzi1bU5dV74ngPS+pWrQ xUZz6BK/4anNdLHeDCltA0sRYmjomO3FLH8/SVTCua/HLKFTspSzgbYC2LJ0qTlNrcOp Y5Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680029423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iZSVb7anGXXb5zwCrWYt7xgUpKRegbsbYrM5HxY90BU=; b=ngLve+En8Y+DFldHXfPsV5GPUjhTZ9cFfDxHJ70fhL647ePNb9txY2qvbtElDTIf1G Ng+1vUOPftX+PUM8RJwr875gMOu2oFwtJ7bx8nwQLjgTHVwOfXc6nuOzA2XhyTnprk1r Wxm+AkgCfSWorVCIIpZnMNgfMF+mRUtFgUIUR9UanQwJg0Jc85DDh/1ZWsLaodlMA/yW jMYFZjCHJIU6UttDCyfday6naxa1aoAiEkG8yGbBGnoMOtfmOXNP2t8F0dthpC1/k5ou 7Y8PsrbitdqqQ2gmi4h7gSEmaEBgwZ6T8gNgKITOyrx4ppqHy8AKut7QLQdVj3M21PEQ Skfg== X-Gm-Message-State: AAQBX9ckqbUstbMAHhhkeJUdg73OpXD6hRG1+hcZLIvOQgFvbiXF9lUI 6lgQYluTQmQfocDO8Xf/md6/Qw== X-Google-Smtp-Source: AKy350YqMLxfTGiBnlGBlam96cEvk7E1kr7TovxbqhmiDlCO1BHyJq1gMHGtAsqa2MLi2frxb39ujQ== X-Received: by 2002:a17:906:3590:b0:8b1:75a0:e5c6 with SMTP id o16-20020a170906359000b008b175a0e5c6mr17691817ejb.18.1680029423006; Tue, 28 Mar 2023 11:50:23 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id h25-20020a1709063c1900b008e8e975e185sm15495056ejg.32.2023.03.28.11.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 11:50:22 -0700 (PDT) Date: Tue, 28 Mar 2023 14:50:21 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates Message-ID: References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-10-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328061638.203420-10-yosryahmed@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 28, 2023 at 06:16:38AM +0000, Yosry Ahmed wrote: > In some situations, we may end up calling memcg_rstat_updated() with a > value of 0, which means the stat was not actually updated. An example is > if we fail to reclaim any pages in shrink_folio_list(). > > Do not add the cgroup to the rstat updated tree in this case, to avoid > unnecessarily flushing it. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner