From: Christoph Hellwig <hch@infradead.org>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com,
hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk,
senozhatsky@chromium.org, akpm@linux-foundation.org,
willy@infradead.org, hch@lst.de, devel@lists.orangefs.org,
mcgrof@kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
gost.dev@samsung.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] mpage: use folios in bio end_io handler
Date: Tue, 4 Apr 2023 08:10:31 -0700 [thread overview]
Message-ID: <ZCw950vAgKCaV00d@infradead.org> (raw)
In-Reply-To: <20230403132221.94921-5-p.raghav@samsung.com>
> + bio_for_each_folio_all(fi, bio) {
> + if (!err)
> + folio_mark_uptodate(fi.folio);
> + else
> + folio_set_error(fi.folio);
> + folio_unlock(fi.folio);
Super nitpicky, but I'd avoid inverted conditions unless there is a
very clear benefit. I.e. I'd rather write this as:
if (err)
folio_set_error(fi.folio);
else
folio_mark_uptodate(fi.folio);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-04-04 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230403132223eucas1p28adb1d36d39add989d46e9f175c07986@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 0/5] remove page_endio() Pankaj Raghav
[not found] ` <CGME20230403132223eucas1p2a27e8239b8bda4fc16b675a9473fd61f@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 1/5] zram: always chain bio to the parent in read_from_bdev_async Pankaj Raghav
2023-04-03 21:19 ` Minchan Kim
2023-04-04 15:06 ` Christoph Hellwig
2023-04-04 19:31 ` Andrew Morton
2023-04-05 6:07 ` Christoph Hellwig
2023-04-11 7:34 ` Pankaj Raghav
[not found] ` <CGME20230403132224eucas1p28f82802bc40d4feb5a30bb59c6536ab3@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-04-04 15:07 ` Christoph Hellwig
[not found] ` <CGME20230403132224eucas1p21fd296fbd4af70220331bb19023f4169@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 3/5] mpage: split bi_end_io callback for reads and writes Pankaj Raghav
2023-04-04 15:09 ` Christoph Hellwig
[not found] ` <CGME20230403132225eucas1p15848db3c850e950b21b339d5861080e1@eucas1p1.samsung.com>
2023-04-03 13:22 ` [PATCH v2 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
2023-04-04 15:10 ` Christoph Hellwig [this message]
[not found] ` <CGME20230403132226eucas1p182e09f5da7bc0bd284d6a8494cd40903@eucas1p1.samsung.com>
2023-04-03 13:22 ` [PATCH v2 5/5] filemap: remove page_endio() Pankaj Raghav
2023-04-04 15:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCw950vAgKCaV00d@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).