From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77122C6FD1D for ; Tue, 4 Apr 2023 15:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235854AbjDDPrI (ORCPT ); Tue, 4 Apr 2023 11:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235758AbjDDPrI (ORCPT ); Tue, 4 Apr 2023 11:47:08 -0400 Received: from out-23.mta1.migadu.com (out-23.mta1.migadu.com [95.215.58.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60391EC for ; Tue, 4 Apr 2023 08:47:07 -0700 (PDT) Date: Tue, 4 Apr 2023 11:47:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680623224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DIGWXQ9vv3X++kkU2M6IyO4Hkx0enP0cYM7Gzv29lqg=; b=WPnTKr/7CYEzdqgByUKoGtMQp9Se4+//Agi0QGz0EHdminhmD5YQ4mFxiPFzWb4Y1kbYY0 QbloC2Zd82EgSQpc8ZycxLavom3cg8DnQcQs6m1fip51NcclGmgS8pUmTgqnXWdR+Du+kn dHw48G02SbfvQ7EZf8NmNDrJBjB9Sic= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, willy@infradead.org, axboe@kernel.dk Subject: Re: [PATCH 0/2] bio iter improvements Message-ID: References: <20230327174402.1655365-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 04, 2023 at 08:20:01AM -0700, Christoph Hellwig wrote: > On Mon, Apr 03, 2023 at 12:36:20PM -0400, Kent Overstreet wrote: > > But this was all right there in the original commit message. And to be > > honest Christoph, these kinds of drive by "let's focus on the easiest > > thing to measure" comments are what I expect from you at this point, > > I'm really just curious what the motivation is. The code does not > seem much cleaner to me as the user of the API, and it doesn't reduce > code size. Maybe there is a good reason for it, but then it needs to > be very clearly stated and you need to sell people on it. Yeah, you're not trying to advance the discussion here, you're just restating your original position. I heard you, and I responded. > Starting to get personal instead tends to not help to convince your > reviewers that it's really useful in general. I know you and others like to talk a lot about what you want as maintainers and reviewers - but I find that the people who are the loudest and the most authoritarian in that respect tend not to be the people who drive discussions forward in productive ways.