From: Mike Snitzer <snitzer@kernel.org>
To: Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Cc: Yu Kuai <yukuai1@huaweicloud.com>,
shinichiro.kawasaki@wdc.com,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"yangerkun@huawei.com" <yangerkun@huawei.com>,
"yi.zhang@huawei.com" <yi.zhang@huawei.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"yukuai (C)" <yukuai3@huawei.com>,
Li Lingfeng <lilingfeng3@huawei.com>,
Joe Thornber <ejt@redhat.com>
Subject: Re: [PATCH blktests] dm: add a regression test
Date: Tue, 25 Apr 2023 13:24:10 -0400 [thread overview]
Message-ID: <ZEgMuvNCud3fNdl4@redhat.com> (raw)
In-Reply-To: <oklvotdaxnncrugr2v7yqadzyfa5vvzrumrfv46vrzowjw3njo@tlvhd4eo5spl>
On Tue, Apr 25 2023 at 8:15P -0400,
Shin'ichiro Kawasaki <shinichiro@fastmail.com> wrote:
> On Apr 25, 2023 / 16:22, Yu Kuai wrote:
> > Hi,
> >
> > 在 2023/01/12 9:05, Shinichiro Kawasaki 写道:
> > > Hello Yu, thanks for the patch. I think it is good to have this test case to
> > > avoid repeating the same regression. Please find my comments in line.
> > >
> > > CC+: Mike, dm-devel,
> > >
> > > Mike, could you take a look in this new test case? It adds "dm" test group to
> > > blktests. If you have thoughts on how to add device-mapper related test cases
> > > to blktests, please share (Or we may be able to discuss later at LSF 2023).
> >
> > Can we add "dm" test group to blktests? I'll send a new version if we
> > can.
>
> I suggest to wait for LSF discussion in May, which could be a good chance to
> hear opinions of dm experts. I think your new test case is valuable, so IMO it
> should be added to the new "dm" group, or at least to the existing "block"
> group. Let's decide the target group after LSF.
>
It's obviously fine to add a new "dm" test group to blktests.
But just so others are aware: more elaborate dm testing is currently
spread across multiple testsuites (e.g. lvm2, cryptsetup, mptest,
device-mapper-test-suite, etc).
There is new effort to port device-mapper-test-suite tests (which use
ruby) to a new python harness currently named "dmtest-python", Joe
Thornber is leading this effort (with the assistance of
ChatGPT.. apparently it has been wonderful in helping Joe glue python
code together to accomplish anything he's needed):
https://github.com/jthornber/dmtest-python
(we've discussed renaming "dmtest-python" to "dmtests")
I've also discussed with Joe the plan to wrap the other disparate
testsuites with DM coverage in terms of the new dmtest-python.
blktests can be made to be one of the testsuites we add support for
(so that all blktests run on various types of DM targets).
Really all we need is a means to:
1) list all tests in a testsuite
2) initiate running each test individually
Mike
next prev parent reply other threads:[~2023-04-25 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 6:54 [PATCH blktests] dm: add a regression test Yu Kuai
2022-12-30 22:24 ` kernel test robot
2023-01-12 1:05 ` Shinichiro Kawasaki
2023-04-25 8:22 ` Yu Kuai
2023-04-25 12:15 ` Shin'ichiro Kawasaki
2023-04-25 17:24 ` Mike Snitzer [this message]
2023-04-26 8:42 ` Chaitanya Kulkarni
2023-04-26 12:13 ` Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEgMuvNCud3fNdl4@redhat.com \
--to=snitzer@kernel.org \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=hch@infradead.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=shinichiro@fastmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox