From: Christoph Hellwig <hch@infradead.org>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] zram: allow user to set QUEUE_FLAG_NOWAIT
Date: Fri, 12 May 2023 07:31:14 -0700 [thread overview]
Message-ID: <ZF5NssjIVNUU9oIA@infradead.org> (raw)
In-Reply-To: <20230512082958.6550-2-kch@nvidia.com>
On Fri, May 12, 2023 at 01:29:56AM -0700, Chaitanya Kulkarni wrote:
> Allow user to set the QUEUE_FLAG_NOWAIT optionally using module
> parameter to retain the default behaviour. Also, update respective
> allocation flags in the write path. Following are the performance
> numbers with io_uring fio engine for random read, note that device has
> been populated fully with randwrite workload before taking these
> numbers :-
Why would you add a module option, except to make everyones life hell?
next prev parent reply other threads:[~2023-05-12 14:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 8:29 [PATCH 0/3] zram: queue flag nowait and mior cleanup Chaitanya Kulkarni
2023-05-12 8:29 ` [PATCH 1/3] zram: allow user to set QUEUE_FLAG_NOWAIT Chaitanya Kulkarni
2023-05-12 14:31 ` Christoph Hellwig [this message]
2023-05-12 14:34 ` Jens Axboe
2023-05-13 1:06 ` Chaitanya Kulkarni
2023-05-16 5:51 ` Chaitanya Kulkarni
2023-05-16 13:08 ` Sergey Senozhatsky
2023-05-16 20:41 ` Chaitanya Kulkarni
2023-05-16 20:43 ` Jens Axboe
2023-05-16 21:32 ` Chaitanya Kulkarni
2023-05-16 22:03 ` Jens Axboe
2023-05-13 1:05 ` Chaitanya Kulkarni
2023-05-12 8:29 ` [PATCH 2/3] zram: consolidate zram_bio_read()_zram_bio_write() Chaitanya Kulkarni
2023-05-12 14:32 ` Christoph Hellwig
2023-05-13 1:06 ` Chaitanya Kulkarni
2023-05-12 8:29 ` [PATCH 3/3] zram: add flush_dcache_page() call for write Chaitanya Kulkarni
2023-05-12 14:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF5NssjIVNUU9oIA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).