From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, Guangwu Zhang <guazhang@redhat.com>,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH] blk-mq: don't queue passthrough request into scheduler
Date: Fri, 12 May 2023 13:21:29 -0700 [thread overview]
Message-ID: <ZF6fyc/vFGm56mDO@infradead.org> (raw)
In-Reply-To: <ca934bc6-651a-6c96-0598-105cd4a0b500@kernel.dk>
On Fri, May 12, 2023 at 09:43:32AM -0600, Jens Axboe wrote:
> We really have two types of passthrough - normal kind of IO, and
> potential error recovery etc IO. The former can plug just fine, and I
> don't think we should treat it differently. Might make more sense to
> just bypass plugging for error handling type of IO, or pt that doesn't
> transfer any data to avoid having a NULL bio inserted into the
> scheduler.
I'd suggest we distinguish by ... having a plug or not. Anything
internal like EH or probing should never come from a context with
a plug.
next prev parent reply other threads:[~2023-05-12 20:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 15:03 [PATCH] blk-mq: don't queue passthrough request into scheduler Ming Lei
2023-05-12 15:08 ` Jens Axboe
2023-05-12 15:19 ` Ming Lei
2023-05-12 15:25 ` Jens Axboe
2023-05-12 15:34 ` Ming Lei
2023-05-12 15:43 ` Jens Axboe
2023-05-12 15:55 ` Ming Lei
2023-05-12 16:10 ` Jens Axboe
2023-05-13 10:55 ` Ming Lei
2023-05-12 20:21 ` Christoph Hellwig [this message]
2023-05-12 21:31 ` Jens Axboe
2023-05-12 23:12 ` Christoph Hellwig
2023-05-12 23:14 ` Christoph Hellwig
2023-05-12 20:20 ` Christoph Hellwig
2023-05-13 11:15 ` Ming Lei
2023-05-13 16:50 ` Jens Axboe
2023-05-14 12:11 ` Guangwu Zhang
2023-05-14 12:24 ` Ming Lei
2023-05-15 14:33 ` Guangwu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF6fyc/vFGm56mDO@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=guazhang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox