From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A46C83005 for ; Tue, 6 Jun 2023 23:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240152AbjFFXBG (ORCPT ); Tue, 6 Jun 2023 19:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240159AbjFFXBD (ORCPT ); Tue, 6 Jun 2023 19:01:03 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89CCD172B for ; Tue, 6 Jun 2023 16:01:01 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f736e0c9a8so27286965e9.2 for ; Tue, 06 Jun 2023 16:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686092460; x=1688684460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4AyxSeVCWLu668XQQXcZmNRbTvqm+XfWnbYRI3bfM+o=; b=ap+1NYchKGrYc446kRWRnQbhMV1pl6YsP5OToBbRr7yqxWuwivol/KLqvKwbFREzDt leVawKb5LA6xL6S30/x70zQDywvhkHn7+JCGlKA0lozFIJqWnjRJTp5YJHpex7lWnnUv dJkg9spKjZLznLO62AffDpdqoqWcUVXi8VRvJ792SrSPG5RfZag3TIQLuMV3b7gUNrfh oTcGuFKfS4159jodmD3xpY5/Ko+Rh5RiDBfrQUvcEy89mqnn+LVVNO5Iw2N5Qiu+JIlB FJKkwHEgGck4KgrxHNc30tLse+VJntfkb30BZScrTrWOpflbR4XFpuj885jYKqOuXNkW SBWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686092460; x=1688684460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4AyxSeVCWLu668XQQXcZmNRbTvqm+XfWnbYRI3bfM+o=; b=kcBgCOc9krH0T6pYVY+Oj1pJmKjnFCVqPHG1GrAuEf8ngrJEiQal8r12lHB1j0oQzV u6fS0pGsuAP0/MvQsmqSXaNDvMi2N7yRbIGEcVfjSw0wKLdVGPIZKd1uKkQWe6x6Gecn rzcKNSGMSPKVeWyQZ5K4h2PxOag2neGMFmg9ncM/fS2BKo79J+nUnr94YuiDop4XYuz8 p4NzT6zNmkdu5ae/RFcTUIcyyGdXbeBej5/aLtWEs7hRin97twf/9iVtqhXe6AadC1bW NTcohgrulWRr7QCthxS87U7e3rKC5m2Dxa+nnw3bAzhOI/PXePliZeCB8ZPGLeNGyBTd 9OgQ== X-Gm-Message-State: AC+VfDwLQTTTRRka/C+CPG57PhubvV4OR6DenDrBYMiYglNvqFhI+dEj TWil7/jaZbroEmqk50Qs3vP9Bw== X-Google-Smtp-Source: ACHHUZ5ZvgvojXp46B2yfDhTglh07h4ImH+yrfGSyDnf68I9NldGnBlDJsUdFl1IxgkatnTdfmUXtg== X-Received: by 2002:a1c:4c0d:0:b0:3f5:6e6:9d83 with SMTP id z13-20020a1c4c0d000000b003f506e69d83mr2830681wmf.23.1686092459976; Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u25-20020a7bcb19000000b003f73a101f88sm201447wmj.16.2023.06.06.16.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Date: Wed, 7 Jun 2023 00:00:57 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606073950.225178-7-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 2 +- > drivers/cdrom/gdrom.c | 2 +- > drivers/scsi/sr.c | 2 +- > include/linux/cdrom.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index adebac1bd210d9..998b03fe976e22 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -1250,7 +1250,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi, > return 0; > } > > -void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode) > +void cdrom_release(struct cdrom_device_info *cdi) > { > const struct cdrom_device_ops *cdo = cdi->ops; > > diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c > index 14922403983e9e..a401dc4218a998 100644 > --- a/drivers/cdrom/gdrom.c > +++ b/drivers/cdrom/gdrom.c > @@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode) > bdev_check_media_change(bdev); > > mutex_lock(&gdrom_mutex); > - ret = cdrom_open(gd.cd_info, mode); > + ret = cdrom_open(gd.cd_info); > mutex_unlock(&gdrom_mutex); > return ret; > } > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 444c7efc14cba7..6d33120ee5ba85 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -512,7 +512,7 @@ static void sr_block_release(struct gendisk *disk, fmode_t mode) > struct scsi_cd *cd = scsi_cd(disk); > > mutex_lock(&cd->lock); > - cdrom_release(&cd->cdi, mode); > + cdrom_release(&cd->cdi); > mutex_unlock(&cd->lock); > > scsi_device_put(cd->device); > diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h > index 385e94732b2cf1..3f23d5239de254 100644 > --- a/include/linux/cdrom.h > +++ b/include/linux/cdrom.h > @@ -102,7 +102,7 @@ int cdrom_read_tocentry(struct cdrom_device_info *cdi, > > /* the general block_device operations structure: */ > int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode); > -extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode); > +void cdrom_release(struct cdrom_device_info *cdi); > int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > unsigned int cmd, unsigned long arg); > extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi, > -- > 2.39.2 > Looks good, thanks. Signed-off-by: Phillip Potter Regards, Phil