From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C07EB64D7 for ; Sun, 18 Jun 2023 23:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbjFRXfI (ORCPT ); Sun, 18 Jun 2023 19:35:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjFRXfH (ORCPT ); Sun, 18 Jun 2023 19:35:07 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3946FE47 for ; Sun, 18 Jun 2023 16:35:06 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6b46e540326so517443a34.2 for ; Sun, 18 Jun 2023 16:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1687131305; x=1689723305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fh/QD67RXkBHOuMqDMBgCmptKVZnGnbT6cHL+zbUSS8=; b=lZgAzHZa/Je9B8XgN45KtCbueBGf7YzmwSs7VouPjN2kkneg9+92jCQRLQtFFkv65u VjJx3YV5WCio4L+1wtbUH1vxW1cRQIgiN3fRjiOEEN0zOKuq7sZ/x+2dWGzWeUnqpyHw JUUSl5Zc4EvHIqcI2bIjMvY9u+4oPXZx46C/4KywGVQ2fDuxo2jBmV5xrbXAi0X3aVz9 Uy9zryMjHykSGXL2zfd2fuE1+RUmsDBW9x+HkV1S6TLkMVysh1lHKN+UnANV7mZfEuWa UHVFw3fYKystbr++THU2CT2e+wuz1XXcL4PSbERQjn4QO0WjWGcrbVrJxg/CeskwUzOS pRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687131305; x=1689723305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fh/QD67RXkBHOuMqDMBgCmptKVZnGnbT6cHL+zbUSS8=; b=PdcAn/Tum7TeHLK37amUdfM0q27K+9f1jxCnf3IkUiPA+E5qAwsvlbzDYwVn3MPBeI 1Z9u8eTPz61GMTSRIQsgRGJ5jJ3/jUE/xIMau8bKVE4HC5bTrF68ckPdLEOvBzpasc5v 91ZrggfeT90m7TGOl07WJ9L3LHgZJiY8Fuff2/L5w/jHBTFq48WTEu+C3alCDTMA11+L 21a7spuRBiE70ZnIYzvLAPAkN6BCJz027iDBisILYxls5JGsIyiwsDL+aDTj5WQJZGkm myVa9o/MSZCVu2PvKXZWZH+MAr5TQ57lq5bHBfL0JOBMXAukuU+HC8LG40SUjqm+I3I7 sY3w== X-Gm-Message-State: AC+VfDxmMBLWtKpPR5d+QMSZGve4fma9nNmzgBqR7boc9KmYi7+HSyce PEfoKJI/DLyoS0F9dKwGol2Lww== X-Google-Smtp-Source: ACHHUZ4XLGw6/vMFfxHGld2JCcJ2RIFDx573ZwSIVpvb522QQtnV+YmQECUW5hvMxcuNhEbFaRSVnA== X-Received: by 2002:a9d:6c50:0:b0:6b5:6b95:5876 with SMTP id g16-20020a9d6c50000000b006b56b955876mr728803otq.25.1687131305552; Sun, 18 Jun 2023 16:35:05 -0700 (PDT) Received: from dread.disaster.area (pa49-180-13-202.pa.nsw.optusnet.com.au. [49.180.13.202]) by smtp.gmail.com with ESMTPSA id v9-20020aa78089000000b006475f831838sm10110992pff.30.2023.06.18.16.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 16:35:04 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qB1vB-00DRS8-0J; Mon, 19 Jun 2023 09:35:01 +1000 Date: Mon, 19 Jun 2023 09:35:01 +1000 From: Dave Chinner To: Dmitry Vyukov Cc: "Darrick J. Wong" , Jan Kara , Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Ted Tso , yebin , linux-fsdevel@vger.kernel.org, Kees Cook , Alexander Popov , syzkaller , Eric Biggers Subject: Re: [PATCH] block: Add config option to not allow writing to mounted devices Message-ID: References: <20230612161614.10302-1-jack@suse.cz> <20230614020412.GB11423@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jun 15, 2023 at 11:14:53AM +0200, Dmitry Vyukov wrote: > On Thu, 15 Jun 2023 at 01:38, Dave Chinner wrote: > > Hence the claim that "because syzbot doesn't run we don't have > > visibility of code bugs" is naive, conceited, incredibly > > narcissistic and demonstratable false. It also indicates a very > > poor understanding of where syzbot actually fits into the overall > > engineering processes. > > Hi Dave, Ted, > > We are currently looking into options of how to satisfy all parties. > > I am not saying that all of these bugs need to be fixed, nor that they > are more important than bugs in supported parts. And we are very much > interested in testing supported parts as well as we can do. > > By CONFIG_INSECURE I just meant something similar to kernel taint > bits. How is that any better? Who gets to decide what sets this taint? Subsystem maintainers? > A user is free to continue after any bad thing has happened/they > did, but some warranties are void. And if a kernel developer receives > a bug report on a tainted kernel, they will take it with a grain of > salt. So it's important to note the fact and inform about it. > Something similar here: bugs in deprecated parts do not need to be > fixed, and distros are still free to enable them, but this fact is > acknowledged by distros and made visible to users. "Deprecated" does not mean *unmaintained*. They are two completely different things, and conflating the two does not help anyone. You are talking about marking unmaintained code with a taint, not deprecated code. reiserfs is unmaintained code. ntfs3 is unmaintained code. hfs is unmaintained code. There are several other unmaintained filesystems that don't have active maintainers. Bug reports never, ever get looked at, etc. Sure, there's an argument to taint them. But whilst XFS v4 is deprecated, it is still very much maintained. We encourage people to move off V4, we focus less on it, but if bug reports from users come in, we still fix them. So even if you introduce some "unmaintained" taint for the kernel, you aren't going to see it get set for the XFS V4 format. > But we are looking into other options that won't require even CONFIG_INSECURE. Who is this nebulous "we"? -Dave. -- Dave Chinner david@fromorbit.com