From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>,
linux-block@vger.kernel.org, Chunguang Xu <brookxu.cn@gmail.com>
Subject: Re: [PATCH 2/2] nvme: don't freeze/unfreeze queues from different contexts
Date: Tue, 13 Jun 2023 16:26:27 +0300 [thread overview]
Message-ID: <ZIhugyimdWoW7bU+@sagi-Latitude-7490> (raw)
In-Reply-To: <ZIhtJ3PjJYMWXS04@ovpn-8-16.pek2.redhat.com>
> > > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> > > index 0eb79696fb73..354cce8853c1 100644
> > > --- a/drivers/nvme/host/rdma.c
> > > +++ b/drivers/nvme/host/rdma.c
> > > @@ -918,6 +918,7 @@ static int nvme_rdma_configure_io_queues(struct nvme_rdma_ctrl *ctrl, bool new)
> > > goto out_cleanup_tagset;
> > > if (!new) {
> > > + nvme_start_freeze(&ctrl->ctrl);
> > > nvme_unquiesce_io_queues(&ctrl->ctrl);
> > > if (!nvme_wait_freeze_timeout(&ctrl->ctrl, NVME_IO_TIMEOUT)) {
> > > /*
> > > @@ -926,6 +927,7 @@ static int nvme_rdma_configure_io_queues(struct nvme_rdma_ctrl *ctrl, bool new)
> > > * to be safe.
> > > */
> > > ret = -ENODEV;
> > > + nvme_unfreeze(&ctrl->ctrl);
> >
> > What does this unfreeze designed to do?
>
> It is for undoing the previous nvme_start_freeze.
ok.
next prev parent reply other threads:[~2023-06-13 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 0:58 [PATCH 0/2] nvme: fix two kinds of IO hang from removing NSs Ming Lei
2023-06-13 0:58 ` [PATCH 1/2] nvme: core: unquiesce io queues when removing namespaces Ming Lei
2023-06-13 13:16 ` Sagi Grimberg
2023-06-13 0:58 ` [PATCH 2/2] nvme: don't freeze/unfreeze queues from different contexts Ming Lei
2023-06-13 13:13 ` Sagi Grimberg
2023-06-13 13:20 ` Ming Lei
2023-06-13 13:26 ` Sagi Grimberg [this message]
2023-06-13 14:41 ` Keith Busch
2023-06-13 20:34 ` Sagi Grimberg
2023-06-13 22:43 ` Keith Busch
2023-06-14 0:38 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIhugyimdWoW7bU+@sagi-Latitude-7490 \
--to=sagi@grimberg.me \
--cc=brookxu.cn@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox