From: Christoph Hellwig <hch@infradead.org>
To: Andreas Hindborg <nmi@metaspace.dk>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Hans Holmberg <Hans.Holmberg@wdc.com>,
Andreas Hindborg <a.hindborg@samsung.com>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Johannes Thumshirn <jth@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Matias Bjorling <Matias.Bjorling@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
Minwoo Im <minwoo.im.dev@gmail.com>,
gost.dev@samsung.com, Aravind Ramesh <Aravind.Ramesh@wdc.com>
Subject: Re: [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT
Date: Sun, 9 Jul 2023 23:54:57 -0700 [thread overview]
Message-ID: <ZKurQVJotCwBSHkD@infradead.org> (raw)
In-Reply-To: <20230710064607.155155-2-nmi@metaspace.dk>
On Mon, Jul 10, 2023 at 08:46:04AM +0200, Andreas Hindborg wrote:
> +#define UBLK_IO_OP_WRITE_ZEROES 5
> +/*
> + * Ublk passthrough operation code ranges, and each passthrough operation
> + * provides generic interface between ublk kernel driver and ublk userspace, and
> + * this interface is usually used for handling generic block layer request, such
> + * as command of zoned report zones. Passthrough operation is only needed iff
> + * ublk kernel driver has to be involved for handling this operation.
> + */
> +#define __UBLK_IO_OP_DRV_IN_START 32
> +#define __UBLK_IO_OP_DRV_IN_END 96
> +#define __UBLK_IO_OP_DRV_OUT_START __UBLK_IO_OP_DRV_IN_END
> +#define __UBLK_IO_OP_DRV_OUT_END 160
I guess I was just a little late to catch this before your resend,
sorry. Please look at my comment on the last iteration.
next prev parent reply other threads:[~2023-07-10 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:46 [PATCH v7 0/3] ublk: enable zoned storage support Andreas Hindborg
2023-07-10 6:46 ` [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT Andreas Hindborg
2023-07-10 6:54 ` Christoph Hellwig [this message]
2023-07-10 6:46 ` [PATCH v7 2/3] ublk: add helper to check if device supports user copy Andreas Hindborg
2023-07-10 6:46 ` [PATCH v7 3/3] ublk: enable zoned storage support Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKurQVJotCwBSHkD@infradead.org \
--to=hch@infradead.org \
--cc=Aravind.Ramesh@wdc.com \
--cc=Hans.Holmberg@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gost.dev@samsung.com \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=nmi@metaspace.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).