From: Ming Lei <ming.lei@redhat.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: axboe@kernel.dk, a.hindborg@samsung.com, linux-block@vger.kernel.org
Subject: Re: [PATCH -next] ublk: Fix signedness bug returning warning
Date: Thu, 10 Aug 2023 17:17:54 +0800 [thread overview]
Message-ID: <ZNSrQp+KT02M+GTZ@fedora> (raw)
In-Reply-To: <20230810084836.3535322-1-lizetao1@huawei.com>
On Thu, Aug 10, 2023 at 04:48:36PM +0800, Li Zetao wrote:
> There are two warnings reported by smatch:
>
> drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn:
> signedness bug returning '(-95)'
> drivers/block/ublk_drv.c:963 ublk_setup_iod() warn:
> signedness bug returning '(-5)'
>
> The type of "blk_status_t" is either be a u32 or u8, but this two
> functions return a negative value when not supported or failed. Use
> the error code of the blk module to fix these warnings.
>
> Fixes: 29802d7ca33b ("ublk: enable zoned storage support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202308100201.TCRhgdvN-lkp@intel.com/
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
thanks,
Ming
next prev parent reply other threads:[~2023-08-10 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 8:48 [PATCH -next] ublk: Fix signedness bug returning warning Li Zetao
2023-08-10 9:17 ` Ming Lei [this message]
2023-08-10 13:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNSrQp+KT02M+GTZ@fedora \
--to=ming.lei@redhat.com \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=lizetao1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox