From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5065FC001DB for ; Sat, 12 Aug 2023 20:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbjHLUnl (ORCPT ); Sat, 12 Aug 2023 16:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjHLUnl (ORCPT ); Sat, 12 Aug 2023 16:43:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7684710F2; Sat, 12 Aug 2023 13:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aB77Wk/7coo4TD642I2PGM5/78kptrrLVMQdKyaKs4E=; b=Ym3jI/2h44grHdRLpzf7ao0YDF V6fqK+7zAEHEOs3DXnXGEbJJJvuJWTWRO5OKz6AWWz8YGHkW3M8nHFsaIbFOz23Ts1XJ2LpsXHoxg aBO8P3OGS3PvV3xKy6fRsxaZce++2iPGaMiKTPTTb0jzFpGBfnB8P3mrzs/HOo+5bzDOuFWQ9LF7b JDscWMwRwHURGpYgKWnLo258DoDb4bEd0zw2zwQfFCiWMQmV5xq26vag0sidhRqH6ZdIhKMP3Ddrq huMJiqhGXZSdYgxa2n7YNt9ISkbY5DAyxN82/Pvw/vLgdP7cbMuiW2Oifioez/gRxhS/I9JCAhjPF 43tMMd0A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qUvSD-009TfJ-HK; Sat, 12 Aug 2023 20:43:21 +0000 Date: Sat, 12 Aug 2023 21:43:21 +0100 From: Matthew Wilcox To: Heiko Carstens Cc: Christoph Hellwig , Al Viro , Christian Brauner , Jens Axboe , Denis Efremov , Josef Bacik , Stefan Haberland , Jan Hoeppner , Vasily Gorbik , Alexander Gordeev , "Darrick J . Wong" , Chris Mason , David Sterba , linux-block@vger.kernel.org, nbd@other.debian.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 13/17] block: consolidate __invalidate_device and fsync_bdev Message-ID: References: <20230811100828.1897174-1-hch@lst.de> <20230811100828.1897174-14-hch@lst.de> <20230812105133.GA11904@lst.de> <20230812170400.11613-A-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812170400.11613-A-hca@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Aug 12, 2023 at 07:04:00PM +0200, Heiko Carstens wrote: > On Sat, Aug 12, 2023 at 12:51:33PM +0200, Christoph Hellwig wrote: > > The buildbot pointed out correctly (but rather late), that the special > > s390/dasd export needs a _MODULE postfix, so this will have to be > > folded in: > > > > diff --git a/block/bdev.c b/block/bdev.c > > index 2a035be7f3ee90..a20263fa27a462 100644 > > --- a/block/bdev.c > > +++ b/block/bdev.c > > @@ -967,7 +967,7 @@ void bdev_mark_dead(struct block_device *bdev, bool surprise) > > > > invalidate_bdev(bdev); > > } > > -#ifdef CONFIG_DASD > > +#ifdef CONFIG_DASD_MODULE > > This needs to be > > #if IS_ENABLED(CONFIG_DASD) > > to cover both CONFIG_DASD=y and CONFIG_DASD=m. Sure, but if DASD is built-in, the symbol doesn't need to be exported