From: Ming Lei <ming.lei@redhat.com>
To: chengming.zhou@linux.dev
Cc: axboe@kernel.dk, hch@lst.de, bvanassche@acm.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: Re: [PATCH 3/3] blk-mq: prealloc tags when increase tagset nr_hw_queues
Date: Tue, 22 Aug 2023 20:55:34 +0800 [thread overview]
Message-ID: <ZOSwRtKM75UWDryy@fedora> (raw)
In-Reply-To: <20230821095602.70742-3-chengming.zhou@linux.dev>
On Mon, Aug 21, 2023 at 05:56:02PM +0800, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> Just like blk_mq_alloc_tag_set(), it's better to prepare all tags before
> using to map to queue ctxs in blk_mq_map_swqueue(), which now have to
> consider empty set->tags[].
>
> The good point is that we can fallback easily if increasing nr_hw_queues
> fail, instead of just mapping to hctx[0] when fail in blk_mq_map_swqueue().
>
> And the fallback path already has tags free & clean handling, so all
> is good.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
next prev parent reply other threads:[~2023-08-22 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 9:56 [PATCH 1/3] blk-mq: fix tags leak when shrink nr_hw_queues chengming.zhou
2023-08-21 9:56 ` [PATCH 2/3] blk-mq: delete redundant tagset map update when fallback chengming.zhou
2023-08-22 12:46 ` Ming Lei
2023-08-21 9:56 ` [PATCH 3/3] blk-mq: prealloc tags when increase tagset nr_hw_queues chengming.zhou
2023-08-22 12:55 ` Ming Lei [this message]
2023-08-22 12:45 ` [PATCH 1/3] blk-mq: fix tags leak when shrink nr_hw_queues Ming Lei
2023-08-22 14:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOSwRtKM75UWDryy@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chengming.zhou@linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).