From: Mike Snitzer <snitzer@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sarthak Kukreti <sarthakkukreti@chromium.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
stable@vger.kernel.org, "Darrick J . Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: block: Don't invalidate pagecache for invalid falloc modes
Date: Wed, 11 Oct 2023 16:50:29 -0400 [thread overview]
Message-ID: <ZScKlejOlxIXYmWI@redhat.com> (raw)
In-Reply-To: <b068c2ef-5de3-44fb-a55d-2cbe5a7f1158@kernel.dk>
On Wed, Oct 11 2023 at 4:20P -0400,
Jens Axboe <axboe@kernel.dk> wrote:
> On 10/11/23 2:12 PM, Sarthak Kukreti wrote:
> > Only call truncate_bdev_range() if the fallocate mode is
> > supported. This fixes a bug where data in the pagecache
> > could be invalidated if the fallocate() was called on the
> > block device with an invalid mode.
>
> Fix looks fine, but would be nicer if we didn't have to duplicate the
> truncate_bdev_range() in each switch clause. Can we check this upfront
> instead?
No, if you look at the function (rather than just the patch in
isolation) we need to make the call for each case rather than collapse
to a single call at the front (that's the reason for this fix, because
otherwise the default: error case will invalidate the page cache too).
Just so you're aware, I also had this feedback that shaped the patch a
bit back in April:
https://listman.redhat.com/archives/dm-devel/2023-April/053986.html
> Also, please wrap commit messages at 72-74 chars.
Not seeing where the header should be wrapped. You referring to the
Fixes: line? I've never seen those wrapped.
Mike
next prev parent reply other threads:[~2023-10-11 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 20:12 [PATCH] block: Don't invalidate pagecache for invalid falloc modes Sarthak Kukreti
2023-10-11 20:20 ` Jens Axboe
2023-10-11 20:50 ` Mike Snitzer [this message]
2023-10-11 20:53 ` Jens Axboe
2023-10-11 21:08 ` Mike Snitzer
2023-10-11 21:20 ` Jens Axboe
2023-10-11 21:54 ` [PATCH] " Jens Axboe
2023-10-11 21:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZScKlejOlxIXYmWI@redhat.com \
--to=snitzer@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=darrick.wong@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sarthakkukreti@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).