From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: LOOP_CONFIGURE uevents
Date: Tue, 24 Oct 2023 00:06:26 -0700 [thread overview]
Message-ID: <ZTds8va6evIjnpJG@infradead.org> (raw)
In-Reply-To: <20231023-biberbau-spatzen-282ccea0825a@brauner>
On Mon, Oct 23, 2023 at 04:08:21PM +0200, Christian Brauner wrote:
> No you get uevents if you trigger a partition rescan but only if there
> are actually partitions. What you never get however is a media change
> event even though we do increment the disk sequence number and attach an
> image to the loop device.
>
> This seems problematic because we leave userspace unable to listen for
> attaching images to a loop device. Shouldn't we regenerate the media
> change event after we're done setting up the device and before the
> partition rescan for LOOP_CONFIGURE?
Maybe. I think people mostly didn't care about the even anyway, but
about the changing sequence number to check that the content hasn't
changed.
next prev parent reply other threads:[~2023-10-24 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231018152924.3858-1-jack@suse.cz>
[not found] ` <20231019-galopp-zeltdach-b14b7727f269@brauner>
[not found] ` <ZTExy7YTFtToAOOx@infradead.org>
[not found] ` <20231020-enthusiasmus-vielsagend-463a7c821bf3@brauner>
[not found] ` <20231020120436.jgxdlawibpfuprnz@quack3>
2023-10-23 14:08 ` LOOP_CONFIGURE uevents Christian Brauner
2023-10-24 7:06 ` Christoph Hellwig [this message]
2023-10-24 8:42 ` Christian Brauner
[not found] ` <20231023-ausgraben-berichten-d747aa50d876@brauner>
2023-10-23 15:35 ` loop change deprecation bdev->bd_holder_lock Christian Brauner
2023-10-24 7:03 ` Christoph Hellwig
2023-10-24 8:44 ` loop change deprecation Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTds8va6evIjnpJG@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).