From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] blk-mq: make sure active queue usage is held for bio_integrity_prep()
Date: Thu, 9 Nov 2023 06:34:22 -0800 [thread overview]
Message-ID: <ZUzt7hHEl7SPB9oY@infradead.org> (raw)
In-Reply-To: <ZUyUSBrp+K5pPLPy@fedora>
On Thu, Nov 09, 2023 at 04:11:52PM +0800, Ming Lei wrote:
> > > if (blk_mq_attempt_bio_merge(q, bio, nsegs))
> > > - goto queue_exit;
> > > + return NULL;
> > >
> > > rq_qos_throttle(q, bio);
> >
> > For clarity splitting this out might be a bit more readable.
>
> I'd rather not do too many things in single fix, which need backport,
> but I am fine to do it in following cleanup.
The resulting diff is smaller..
prev parent reply other threads:[~2023-11-09 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 8:05 [PATCH] blk-mq: make sure active queue usage is held for bio_integrity_prep() Ming Lei
2023-11-09 7:30 ` Christoph Hellwig
2023-11-09 8:11 ` Ming Lei
2023-11-09 14:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUzt7hHEl7SPB9oY@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox