From: Matthew Wilcox <willy@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] block: Rework bio_for_each_folio_all(), add bio_for_each_folio()
Date: Thu, 7 Dec 2023 19:02:36 +0000 [thread overview]
Message-ID: <ZXIWzLUUqZ7ld7bb@casper.infradead.org> (raw)
In-Reply-To: <20231122232818.178256-2-kent.overstreet@linux.dev>
On Wed, Nov 22, 2023 at 06:28:14PM -0500, Kent Overstreet wrote:
> /**
> * bio_for_each_folio_all - Iterate over each folio in a bio.
> - * @fi: struct folio_iter which is updated for each folio.
> + * @fi: struct bio_folio_iter_all which is updated for each folio.
> * @bio: struct bio to iterate over.
> */
> -#define bio_for_each_folio_all(fi, bio) \
> - for (bio_first_folio(&fi, bio, 0); fi.folio; bio_next_folio(&fi, bio))
> +#define bio_for_each_folio_all(fv, bio, iter) \
That @fi should be an @fv, no? Does kernel-doc not warn about this
mismatch?
next prev parent reply other threads:[~2023-12-07 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:28 [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-11-22 23:28 ` [PATCH 2/3] block: Rework bio_for_each_folio_all(), add bio_for_each_folio() Kent Overstreet
2023-12-07 19:02 ` Matthew Wilcox [this message]
2023-12-07 20:09 ` Matthew Wilcox
2023-12-07 20:45 ` Keith Busch
2023-12-07 22:11 ` Eric Biggers
2023-11-22 23:28 ` [PATCH 3/3] block: Add documentation for bio iterator macros Kent Overstreet
2023-12-07 9:21 ` Ming Lei
2023-12-06 21:34 ` [PATCH 1/3] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-12-06 22:40 ` Jens Axboe
2023-12-06 23:27 ` Kent Overstreet
2023-12-07 17:57 ` Jens Axboe
2023-12-07 18:06 ` Kent Overstreet
2023-12-07 18:26 ` Jens Axboe
2023-12-07 20:58 ` Matthew Wilcox
2023-12-07 21:01 ` Jens Axboe
2023-12-07 21:04 ` Jens Axboe
2023-12-07 9:20 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXIWzLUUqZ7ld7bb@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox