Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

Yu Kuai
2023-12-13T01:10:11Z

Hi,

在 2023/12/12 21:14, Christoph Hellwig 写道:
> On Mon, Dec 11, 2023 at 05:52:17PM +0100, Jan Kara wrote:
>>> +void bdev_associated_mapping(struct block_device *bdev,
>>> + struct address_space *mapping)
>>> +{
>>> + mapping->host = bdev->bd_inode;
>>> +}
>>
>> Here I'm not sure - is the helper really a win? It seems a bit obscure to
>> me. This initialization of another mapping for a bdev looks really special.
>
> If we want to hide bd_inode we'll something like this helper even if
> I don't particularly like it either.
>
> But it might be a good idea to move out of this series and into the
> follow on removing bd_inode, as it's rather pointless without that
> context.

Yes, this sounds good, I'll remove this from v3.

Thanks,
Kuai

> .
>