From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45BB9AC for ; Wed, 13 Dec 2023 08:58:26 -0800 (PST) Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-67adc37b797so45181876d6.1 for ; Wed, 13 Dec 2023 08:58:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702486705; x=1703091505; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fko4jEZO7IcAc5n2WrXVozicqYAVH+5PpOz25KhjD+M=; b=P5mcvdwxJSW1PXZqGX8DDUKV2pBb4FblMYTPn1ueAMp0h6gghwLrUjAF5JIr7TmGgy 3W7I93EyCbrwVZa44vPwu51Rb7/zAYrZblDgbUNGSK5vVieCSE41RIe9SgmCZPc3jtmO aD//sI60FsWTpnjsGLsUszj8WdxcYl8gBveGq82pN9hkgTwsCAOybu4/x7uSW7PFT6fy ePeI1MfNFyiULMh4SXcI6+X3NIn8A3L9NruTKNyNHrJ8C3+r/2xSN6Ut9GSNbD/Pa2BF ye2h37OASBitRZSGbyu4zm8225O/mDzCPVUZuki/o8tGNw5o/fRZOawjMaGcu+8CDhuZ HOhw== X-Gm-Message-State: AOJu0YwFah9r7uXgou75y/t+ZP3T895zGYrNUdxZfRPeNCUPlgsNu6GD v62Iizeb+nt1TksPYUDhPTUS X-Google-Smtp-Source: AGHT+IFvVkIflp9TiGbkJvpAu1da6qN2nmcyxFmltt+dcHVJ2+E3ImsBHyyCd+RBhaSCAT0Tc+H6Gg== X-Received: by 2002:ad4:5046:0:b0:67e:f3e3:8291 with SMTP id m6-20020ad45046000000b0067ef3e38291mr2273884qvq.12.1702486705405; Wed, 13 Dec 2023 08:58:25 -0800 (PST) Received: from localhost (pool-68-160-141-91.bstnma.fios.verizon.net. [68.160.141.91]) by smtp.gmail.com with ESMTPSA id mi14-20020a056214558e00b0067a276fd8d5sm131380qvb.54.2023.12.13.08.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:58:24 -0800 (PST) Date: Wed, 13 Dec 2023 11:58:23 -0500 From: Mike Snitzer To: Hongyu Jin Cc: agk@redhat.com, mpatocka@redhat.com, axboe@kernel.dk, ebiggers@kernel.org, zhiguo.niu@unisoc.com, ke.wang@unisoc.com, yibin.ding@unisoc.com, hongyu.jin@unisoc.com, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-block@vger.kernel.org Subject: Re: [PATCH v5 1/5] block: Fix bio IO priority setting Message-ID: References: <20231213104216.27845-1-hongyu.jin.cn@gmail.com> <20231213104216.27845-2-hongyu.jin.cn@gmail.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213104216.27845-2-hongyu.jin.cn@gmail.com> On Wed, Dec 13 2023 at 5:42P -0500, Hongyu Jin wrote: > From: Hongyu Jin > > Move bio_set_ioprio() into submit_bio(): > 1. Only call bio_set_ioprio() once to set the priority of original bio, > the bio that cloned and splited from original bio will auto inherit > the priority of original bio in clone process. > > 2. The IO priority can be passed to module that implement > struct gendisk::fops::submit_bio, help resolve some > of the IO priority loss issues. > > This patch depends on commit 82b74cac2849 ("blk-ioprio: Convert from > rqos policy to direct call") > > Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit") > > Co-developed-by: Yibin Ding > Signed-off-by: Yibin Ding > Signed-off-by: Hongyu Jin Would be nice to get this block core fix upstream ASAP independent of your various DM changes. Please simplify this patch's header like was requested in review of v4: https://patchwork.kernel.org/project/dm-devel/patch/20231212111150.18155-2-hongyu.jin.cn@gmail.com/