From: Keith Busch <kbusch@kernel.org>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
nitheshshetty@gmail.com, anuj1072538@gmail.com,
gost.dev@samsung.com, mcgrof@kernel.org,
Nitesh Shetty <nj.shetty@samsung.com>,
Anuj Gupta <anuj20.g@samsung.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v18 02/12] Add infrastructure for copy offload in block and request layer.
Date: Wed, 13 Dec 2023 17:11:21 -0800 [thread overview]
Message-ID: <ZXpWOaxCRoF7dFis@kbusch-mbp> (raw)
In-Reply-To: <20231206100253.13100-3-joshi.k@samsung.com>
On Wed, Dec 06, 2023 at 03:32:34PM +0530, Kanchan Joshi wrote:
> static inline bool bio_has_data(struct bio *bio)
> {
> - if (bio &&
> - bio->bi_iter.bi_size &&
> - bio_op(bio) != REQ_OP_DISCARD &&
> - bio_op(bio) != REQ_OP_SECURE_ERASE &&
> - bio_op(bio) != REQ_OP_WRITE_ZEROES)
> + if (bio && (bio_op(bio) == REQ_OP_READ || bio_op(bio) == REQ_OP_WRITE))
> return true;
There are other ops besides READ and WRITE that have data, but this is
might be fine by the fact that other ops with data currently don't call
this function.
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 7c2316c91cbd..bd821eaa7a02 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -393,6 +393,10 @@ enum req_op {
> /* reset all the zone present on the device */
> REQ_OP_ZONE_RESET_ALL = (__force blk_opf_t)17,
>
> + /* copy offload dst and src operation */
> + REQ_OP_COPY_SRC = (__force blk_opf_t)19,
Should this be an even numbered OP? The odd ones are for data
WRITEs.
> + REQ_OP_COPY_DST = (__force blk_opf_t)21,
next prev parent reply other threads:[~2023-12-14 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231206101018epcas5p1c4f2dc5149853412918e0270314f96b0@epcas5p1.samsung.com>
2023-12-06 10:02 ` [PATCH v18 00/12] Implement copy offload support Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 01/12] block: Introduce queue limits and sysfs for copy-offload support Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 02/12] Add infrastructure for copy offload in block and request layer Kanchan Joshi
2023-12-14 1:11 ` Keith Busch [this message]
2023-12-16 18:16 ` Nitesh Shetty
2023-12-06 10:02 ` [PATCH v18 03/12] block: add copy offload support Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 04/12] block: add emulation for copy Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 05/12] fs/read_write: Enable copy_file_range for block device Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 06/12] fs, block: copy_file_range for def_blk_ops for direct " Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 07/12] nvme: add copy offload support Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 08/12] nvmet: add copy command support for bdev and file ns Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 09/12] dm: Add support for copy offload Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 10/12] dm: Enable copy offload for dm-linear target Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 11/12] null: Enable trace capability for null block Kanchan Joshi
2023-12-06 10:02 ` [PATCH v18 12/12] null_blk: add support for copy offload Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXpWOaxCRoF7dFis@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=agk@redhat.com \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mpatocka@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox