[PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd() call in null_zone_write()

[PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd() call in null_zone_write()

[Sasha Levin]

From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

[ Upstream commit 4f235000b1e88934d1e6117dc43ed814710ef4e2 ]

As a preparation to support partial data transfer due to badblocks,
replace the null_process_cmd() call in null_zone_write() with equivalent
calls to null_handle_badblocks() and null_handle_memory_backed(). This
commit does not change behavior. It will enable null_handle_badblocks()
to return the size of partial data transfer in the following commit,
allowing null_zone_write() to move write pointers appropriately.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Link: https://lore.kernel.org/r/20250226100613.1622564-4-shinichiro.kawasaki@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/block/null_blk/main.c     | 11 ++++-------
 drivers/block/null_blk/null_blk.h |  5 +++++
 drivers/block/null_blk/zoned.c    | 15 ++++++++++++---
 3 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index fdc7a0b2af109..22ed6eb82cb05 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1295,9 +1295,8 @@ static inline blk_status_t null_handle_throttled(struct nullb_cmd *cmd)
 	return sts;
 }
 
-static inline blk_status_t null_handle_badblocks(struct nullb_cmd *cmd,
-						 sector_t sector,
-						 sector_t nr_sectors)
+blk_status_t null_handle_badblocks(struct nullb_cmd *cmd, sector_t sector,
+				   sector_t nr_sectors)
 {
 	struct badblocks *bb = &cmd->nq->dev->badblocks;
 	sector_t first_bad;
@@ -1309,10 +1308,8 @@ static inline blk_status_t null_handle_badblocks(struct nullb_cmd *cmd,
 	return BLK_STS_OK;
 }
 
-static inline blk_status_t null_handle_memory_backed(struct nullb_cmd *cmd,
-						     enum req_op op,
-						     sector_t sector,
-						     sector_t nr_sectors)
+blk_status_t null_handle_memory_backed(struct nullb_cmd *cmd, enum req_op op,
+				       sector_t sector, sector_t nr_sectors)
 {
 	struct nullb_device *dev = cmd->nq->dev;
 
diff --git a/drivers/block/null_blk/null_blk.h b/drivers/block/null_blk/null_blk.h
index 6f9fe61710870..c6630fc0b074c 100644
--- a/drivers/block/null_blk/null_blk.h
+++ b/drivers/block/null_blk/null_blk.h
@@ -131,6 +131,11 @@ blk_status_t null_handle_discard(struct nullb_device *dev, sector_t sector,
 				 sector_t nr_sectors);
 blk_status_t null_process_cmd(struct nullb_cmd *cmd, enum req_op op,
 			      sector_t sector, unsigned int nr_sectors);
+blk_status_t null_handle_badblocks(struct nullb_cmd *cmd, sector_t sector,
+				   sector_t nr_sectors);
+blk_status_t null_handle_memory_backed(struct nullb_cmd *cmd, enum req_op op,
+				       sector_t sector, sector_t nr_sectors);
+
 
 #ifdef CONFIG_BLK_DEV_ZONED
 int null_init_zoned_dev(struct nullb_device *dev, struct queue_limits *lim);
diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c
index 0d5f9bf952292..7677f6cf23f46 100644
--- a/drivers/block/null_blk/zoned.c
+++ b/drivers/block/null_blk/zoned.c
@@ -412,9 +412,18 @@ static blk_status_t null_zone_write(struct nullb_cmd *cmd, sector_t sector,
 		zone->cond = BLK_ZONE_COND_IMP_OPEN;
 	}
 
-	ret = null_process_cmd(cmd, REQ_OP_WRITE, sector, nr_sectors);
-	if (ret != BLK_STS_OK)
-		goto unlock_zone;
+	if (dev->badblocks.shift != -1) {
+		ret = null_handle_badblocks(cmd, sector, nr_sectors);
+		if (ret != BLK_STS_OK)
+			goto unlock_zone;
+	}
+
+	if (dev->memory_backed) {
+		ret = null_handle_memory_backed(cmd, REQ_OP_WRITE, sector,
+						nr_sectors);
+		if (ret != BLK_STS_OK)
+			goto unlock_zone;
+	}
 
 	zone->wp += nr_sectors;
 	if (zone->wp == zone->start + zone->capacity) {
-- 
2.39.5

Re: [PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd() call in null_zone_write()

[Shinichiro Kawasaki]

On Apr 03, 2025 / 15:01, Sasha Levin wrote:
> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> 
> [ Upstream commit 4f235000b1e88934d1e6117dc43ed814710ef4e2 ]
> 
> As a preparation to support partial data transfer due to badblocks,
> replace the null_process_cmd() call in null_zone_write() with equivalent
> calls to null_handle_badblocks() and null_handle_memory_backed(). This
> commit does not change behavior. It will enable null_handle_badblocks()
> to return the size of partial data transfer in the following commit,
> allowing null_zone_write() to move write pointers appropriately.

Hello Sasha, I don't think this patch should be in stable kernels, since it
just refactors code as a preparation for another patch. I suggest to drop it
for all stable kernels.

Re: [PATCH AUTOSEL 6.14 29/54] null_blk: replace null_process_cmd() call in null_zone_write()

[Sasha Levin]

On Fri, Apr 04, 2025 at 03:31:03AM +0000, Shinichiro Kawasaki wrote:
>On Apr 03, 2025 / 15:01, Sasha Levin wrote:
>> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>>
>> [ Upstream commit 4f235000b1e88934d1e6117dc43ed814710ef4e2 ]
>>
>> As a preparation to support partial data transfer due to badblocks,
>> replace the null_process_cmd() call in null_zone_write() with equivalent
>> calls to null_handle_badblocks() and null_handle_memory_backed(). This
>> commit does not change behavior. It will enable null_handle_badblocks()
>> to return the size of partial data transfer in the following commit,
>> allowing null_zone_write() to move write pointers appropriately.
>
>Hello Sasha, I don't think this patch should be in stable kernels, since it
>just refactors code as a preparation for another patch. I suggest to drop it
>for all stable kernels.

I'll drop it, thanks!

-- 
Thanks,
Sasha