From: Christoph Hellwig <hch@infradead.org>
To: Yunlong Xing <yunlong.xing@unisoc.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, bvanassche@acm.org,
niuzhiguo84@gmail.com, yunlongxing23@gmail.com,
linux-kernel@vger.kernel.org, hao_hao.wang@unisoc.com,
zhiguo.niu@unisoc.com
Subject: Re: [PATCH V2] loop: aio inherit the ioprio of original request
Date: Sun, 13 Apr 2025 23:12:29 -0700 [thread overview]
Message-ID: <Z_ynTcEZGhPKm5wY@infradead.org> (raw)
In-Reply-To: <20250414030159.501180-1-yunlong.xing@unisoc.com>
On Mon, Apr 14, 2025 at 11:01:59AM +0800, Yunlong Xing wrote:
> Set cmd->iocb.ki_ioprio to the ioprio of loop device's request.
> The purpose is to inherit the original request ioprio in the aio
> flow.
This looks good, but has a mechanical conflict with my
"loop: stop using vfs_iter_{read,write} for buffered I/O" patch
that fixes setting the block size for direct I/O.
Jens, any preference how we should order the patches? Should I resend
on top of this smaller one or the other way around?
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-04-14 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 3:01 [PATCH V2] loop: aio inherit the ioprio of original request Yunlong Xing
2025-04-14 6:12 ` Christoph Hellwig [this message]
2025-04-14 14:47 ` Jens Axboe
2025-04-16 4:32 ` Christoph Hellwig
2025-04-16 14:58 ` Jens Axboe
2025-04-14 14:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_ynTcEZGhPKm5wY@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hao_hao.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=yunlong.xing@unisoc.com \
--cc=yunlongxing23@gmail.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox