From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, song@kernel.org, yukuai3@huawei.com,
xni@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH 1/4] block: export part_in_flight()
Date: Sun, 13 Apr 2025 23:32:11 -0700 [thread overview]
Message-ID: <Z_yr67xrbkuQwy0P@infradead.org> (raw)
In-Reply-To: <20250412073202.3085138-2-yukuai1@huaweicloud.com>
On Sat, Apr 12, 2025 at 03:31:59PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> This helper will be used in mdraid in later patches, check if there
> are normal IO inflight while generating background sync IO, to fix a
> problem in mdraid that foreground IO can be starved by background sync
> IO.
If we export this it needs a kerneldoc comment, and probably also
a better name.
Looking at this I'm also a little confused about blk_mq_in_flight_rw vs
blk_mq_in_flight and why one needs blk-mq special casing and the other
not, maybe we need to dig into the history and try to understand that
as well while we're at it.
next prev parent reply other threads:[~2025-04-14 6:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 7:31 [PATCH 0/4] md: fix is_mddev_idle() Yu Kuai
2025-04-12 7:31 ` [PATCH 1/4] block: export part_in_flight() Yu Kuai
2025-04-14 6:32 ` Christoph Hellwig [this message]
2025-04-14 6:48 ` Yu Kuai
2025-04-14 11:39 ` Christoph Hellwig
2025-04-12 7:32 ` [PATCH 2/4] md: add a new api sync_io_depth Yu Kuai
2025-04-16 5:32 ` Xiao Ni
2025-04-16 8:19 ` Yu Kuai
2025-04-12 7:32 ` [PATCH 3/4] md: fix is_mddev_idle() Yu Kuai
2025-04-16 6:20 ` Xiao Ni
2025-04-16 7:42 ` Yu Kuai
2025-04-16 9:28 ` Yu Kuai
2025-04-16 9:44 ` Xiao Ni
2025-04-17 1:47 ` Yu Kuai
2025-04-12 7:32 ` [PATCH 4/4] md: cleanup accounting for issued sync IO Yu Kuai
2025-04-16 6:27 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_yr67xrbkuQwy0P@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox