public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Allison Karlitskaya <allison.karlitskaya@redhat.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: PROBLEM: BLKPG_DEL_PARTITION with GENHD_FL_NO_PART used to return ENXIO, now returns EINVAL
Date: Wed, 17 Jan 2024 10:34:45 -0800	[thread overview]
Message-ID: <Zagdxacc9ffD7WtW@infradead.org> (raw)
In-Reply-To: <592625f7-36d7-02e0-2ee6-8211334aa0f9@huaweicloud.com>

On Tue, Jan 16, 2024 at 09:46:21PM +0800, Yu Kuai wrote:
> Please ignore the patch from last email. Sorry for the noise...
> bdev_resize_partition() will also return -ENXIO if partition does't
> exist. So the right patch should be following:

Yes, this looks good.  I've also verified that historically
adding a partition always returned -EINVAL when beyond the maximum
number of partitions (which would have been 0 in this case).

  reply	other threads:[~2024-01-17 18:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 12:13 PROBLEM: BLKPG_DEL_PARTITION with GENHD_FL_NO_PART used to return ENXIO, now returns EINVAL Allison Karlitskaya
2024-01-15 12:57 ` Karel Zak
2024-01-15 14:25   ` Jens Axboe
2024-01-16 10:47 ` Christoph Hellwig
2024-01-16 13:03   ` Allison Karlitskaya
2024-01-16 13:23   ` Yu Kuai
2024-01-16 13:46     ` Yu Kuai
2024-01-17 18:34       ` Christoph Hellwig [this message]
2024-01-17 23:05       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zagdxacc9ffD7WtW@infradead.org \
    --to=hch@infradead.org \
    --cc=allison.karlitskaya@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox