From: Christoph Hellwig <hch@infradead.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] bdev: make blockdev_mnt static
Date: Wed, 28 Feb 2024 05:28:56 -0800 [thread overview]
Message-ID: <Zd81GHuI7y9s0iuu@infradead.org> (raw)
In-Reply-To: <20240227081958.89092-1-jiapeng.chong@linux.alibaba.com>
On Tue, Feb 27, 2024 at 04:19:58PM +0800, Jiapeng Chong wrote:
> The blockdev_mnt are not used outside the file bdev.c, so the modification
> is defined as static.
>
> block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?
>
The patch looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8341
But I don't think kernel commit should close random bugzillas?
next prev parent reply other threads:[~2024-02-28 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:19 [PATCH] bdev: make blockdev_mnt static Jiapeng Chong
2024-02-28 13:28 ` Christoph Hellwig [this message]
2024-02-28 14:21 ` Jens Axboe
2024-05-09 13:29 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd81GHuI7y9s0iuu@infradead.org \
--to=hch@infradead.org \
--cc=abaci@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox