From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.org
Subject: Re: [PATCH] blk-lib: let user kill a zereout process
Date: Wed, 21 Feb 2024 09:27:59 -0700 [thread overview]
Message-ID: <ZdYkj2YfKCpdIhGx@kbusch-mbp> (raw)
In-Reply-To: <1599adf2-3099-457d-a194-3be0057d344e@linux.ibm.com>
On Wed, Feb 21, 2024 at 02:16:23PM +0530, Nilay Shroff wrote:
> On 2/21/24 02:11, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
>
> # time blkdiscard -z /dev/nvme0n1
>
> real 10m27.514s
> user 0m0.000s
> sys 0m0.369s
>
> So shouldn't we need to add the same code (allowing user to kill the process) under
> __blkdev_issue_write_zeroes()? I think even though a drive supports "write zero offload", if
> drive has a very large capacity then it would take up a lot of time to zero out the complete drive.
> Yes the time required may not be in hours in this case but it could be in tens of minutes depending
> on the drive capacity.
Yeah, that's long enough to change your mind and not want to wait around
for it to proceed anyway. Between that and the filesystem usage, looks
like I have more things to consider for v2.
prev parent reply other threads:[~2024-02-21 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 20:41 [PATCH] blk-lib: let user kill a zereout process Keith Busch
2024-02-21 3:05 ` Chaitanya Kulkarni
2024-02-21 3:16 ` Keith Busch
2024-02-21 3:21 ` Keith Busch
2024-02-21 5:32 ` Chaitanya Kulkarni
2024-02-21 8:54 ` Ming Lei
2024-02-21 9:45 ` Chaitanya Kulkarni
2024-02-21 8:46 ` Nilay Shroff
2024-02-21 9:46 ` Chaitanya Kulkarni
2024-02-21 16:27 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdYkj2YfKCpdIhGx@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox