From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.org,
ming.lei@redhat.com, chaitanyak@nvidia.com,
Conrad Meyer <conradmeyer@meta.com>
Subject: Re: [PATCHv3 4/4] blk-lib: check for kill signal
Date: Fri, 23 Feb 2024 08:58:45 -0700 [thread overview]
Message-ID: <ZdjAtdut9Pkgq_79@kbusch-mbp> (raw)
In-Reply-To: <50f7c805-d562-4084-8f4f-4bf0e223ddde@linux.ibm.com>
On Fri, Feb 23, 2024 at 04:30:14PM +0530, Nilay Shroff wrote:
> I think if fatal signal is intercepted while running __blkdev_issue_write_zeroes() then we
> shouldn't need to re-enter the __blkdev_issue_zero_pages(). We may want to add following code:
>
> @@ -280,7 +306,7 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
> bio_put(bio);
> }
> blk_finish_plug(&plug);
> - if (ret && try_write_zeroes) {
> + if (ret && ret != -EINTR && try_write_zeroes) {
> if (!(flags & BLKDEV_ZERO_NOFALLBACK)) {
> try_write_zeroes = false;
> goto retry;
Good point, I'll fold this in.
next prev parent reply other threads:[~2024-02-23 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 19:19 [PATCHv3 0/4] block: make long runnint operations killable Keith Busch
2024-02-22 19:19 ` [PATCHv3 1/4] block: blkdev_issue_secure_erase loop style Keith Busch
2024-02-23 3:22 ` Ming Lei
2024-02-23 6:41 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 2/4] block: __blkdev_issue_write_zeroes cleanup Keith Busch
2024-02-23 3:29 ` Ming Lei
2024-02-23 6:42 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 3/4] block: introduce io wait hang check helper Keith Busch
2024-02-23 3:31 ` Ming Lei
2024-02-23 6:43 ` Christoph Hellwig
2024-02-22 19:19 ` [PATCHv3 4/4] blk-lib: check for kill signal Keith Busch
2024-02-23 3:38 ` Ming Lei
2024-02-23 6:46 ` Christoph Hellwig
2024-02-23 11:00 ` Nilay Shroff
2024-02-23 15:58 ` Keith Busch [this message]
2024-02-23 11:25 ` [PATCHv3 0/4] block: make long runnint operations killable Nilay Shroff
2024-02-23 15:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdjAtdut9Pkgq_79@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=conradmeyer@meta.com \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).