From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.org" <axboe@kernel.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"nilay@linux.ibm.com" <nilay@linux.ibm.com>
Subject: Re: [PATCHv4 0/4] block: make long running operations killable
Date: Fri, 23 Feb 2024 12:31:58 -0700 [thread overview]
Message-ID: <Zdjyrvfy7aELykoS@kbusch-mbp> (raw)
In-Reply-To: <1a81ef8d-023b-4a87-a71d-a31dddf3106c@nvidia.com>
On Fri, Feb 23, 2024 at 07:16:30PM +0000, Chaitanya Kulkarni wrote:
> On 2/23/24 07:59, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > Changes from v3:
> >
> > Added reviewed and tested by tags
> >
> > More formatting cleanups in patch 2 (Christoph)
> >
> > A more descriptive name for the bio chain wait helper (Christoph)
> >
> > Don't fallback to the zero page on fatal signal error (Nilay)
> >
>
> we need a blktests for this, for whole series :-
How would you know know if the device completed the operation before the
fatal signal or not? This is a quick test script off the top of my head,
but whether or not it shows a difference with this patch series depends
on your device.
# time sh -c "blkdiscard -z /dev/nvme0n1 & sleep 1 && kill %1 && wait"
next prev parent reply other threads:[~2024-02-23 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 15:59 [PATCHv4 0/4] block: make long running operations killable Keith Busch
2024-02-23 15:59 ` [PATCHv4 1/4] block: blkdev_issue_secure_erase loop style Keith Busch
2024-02-23 15:59 ` [PATCHv4 2/4] block: cleanup __blkdev_issue_write_zeroes Keith Busch
2024-02-23 16:19 ` Christoph Hellwig
2024-02-23 15:59 ` [PATCHv4 3/4] block: io wait hang check helper Keith Busch
2024-02-23 15:59 ` [PATCHv4 4/4] blk-lib: check for kill signal Keith Busch
2024-02-23 16:19 ` Christoph Hellwig
2024-02-24 7:05 ` Nilay Shroff
2024-02-23 19:16 ` [PATCHv4 0/4] block: make long running operations killable Chaitanya Kulkarni
2024-02-23 19:31 ` Keith Busch [this message]
2024-02-25 7:40 ` Chaitanya Kulkarni
2024-02-25 7:53 ` Chaitanya Kulkarni
2024-02-24 19:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdjyrvfy7aELykoS@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox