From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Johannes Weiner <hannes@cmpxchg.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [GIT PULL] Block updates for 6.9-rc1
Date: Mon, 11 Mar 2024 18:09:26 -0700 [thread overview]
Message-ID: <Ze-rRvKpux44ueao@infradead.org> (raw)
In-Reply-To: <Ze-hwnd3ocfJc9xU@redhat.com>
On Mon, Mar 11, 2024 at 08:28:50PM -0400, Mike Snitzer wrote:
> All for Jens being made to suffer with dm-crypt but I think we need a
> proper root cause of what is happening for you and Johannes ;)
I'm going to try to stay out of the cranking, but I think the reason is
that the limits stacking inherits the max_segment_size, nvme has weird
rules for them due their odd PRPs, and dm-crypt set it's own
max_segment_size to split out each page. The regression here is
that we now actually verify that conflict.
So this happens only for dm-crypt on nvme. The fix is probably
to not inherit low-level limits like max_segment_size, but I need
to think about it a bit more and come up with an automated test case
using say nvme-loop.
So for now the revert is the right thing.
next prev parent reply other threads:[~2024-03-12 1:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 20:30 [GIT PULL] Block updates for 6.9-rc1 Jens Axboe
2024-03-11 19:43 ` pr-tracker-bot
2024-03-11 23:50 ` Johannes Weiner
2024-03-11 23:53 ` Jens Axboe
2024-03-11 23:58 ` Linus Torvalds
2024-03-12 0:02 ` Jens Axboe
2024-03-12 0:21 ` Linus Torvalds
2024-03-12 0:28 ` Mike Snitzer
2024-03-12 1:03 ` Jens Axboe
2024-03-12 1:09 ` Christoph Hellwig [this message]
2024-03-12 1:17 ` Jens Axboe
2024-03-12 1:20 ` Linus Torvalds
2024-03-12 1:23 ` Jens Axboe
2024-03-12 1:28 ` Linus Torvalds
2024-03-12 1:37 ` Jens Axboe
2024-03-12 16:39 ` Keith Busch
2024-03-12 11:53 ` Christoph Hellwig
2024-03-12 15:25 ` Jens Axboe
2024-03-12 11:52 ` Christoph Hellwig
2024-03-12 15:22 ` Mike Snitzer
2024-03-12 16:28 ` Keith Busch
2024-03-12 21:10 ` Christoph Hellwig
2024-03-12 22:22 ` Mike Snitzer
2024-03-12 22:30 ` Christoph Hellwig
2024-03-12 22:50 ` Mike Snitzer
2024-03-12 22:58 ` Christoph Hellwig
2024-04-11 20:15 ` [PATCH for-6.10 0/2] dm: use late bio-splitting and queue_limits_set Mike Snitzer
2024-04-11 20:15 ` [PATCH for-6.10 1/2] dm-crypt: stop constraining max_segment_size to PAGE_SIZE Mike Snitzer
2024-04-12 6:11 ` Christoph Hellwig
2024-04-15 14:08 ` Mikulas Patocka
2024-04-23 7:32 ` Ming Lei
2024-04-11 20:15 ` [PATCH for-6.10 2/2] dm: use queue_limits_set Mike Snitzer
2024-04-23 7:33 ` Ming Lei
2024-03-13 13:11 ` [GIT PULL] Block updates for 6.9-rc1 Ming Lei
2024-03-12 1:01 ` Jens Axboe
2024-03-12 0:25 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze-rRvKpux44ueao@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox