From: Christoph Hellwig <hch@infradead.org>
To: Zhengxu Zhang <zhengxu.zhang@unisoc.com>
Cc: axboe@kernel.dk, bvanassche@acm.org, linux-block@vger.kernel.org,
hongyu.jin.cn@gmail.com, zhiguo.niu@unisoc.com,
niuzhiguo84@gmail.com, hongyu.jin@unisoc.com,
yunlongxing23@gmail.com, char.zzx@gmail.com, ke.wang@unisoc.com
Subject: Re: [PATCH] block: Minimize the number of requests in Direct I/O when bio get pages.
Date: Wed, 13 Mar 2024 14:49:46 -0700 [thread overview]
Message-ID: <ZfIfejdNTL8oassd@infradead.org> (raw)
In-Reply-To: <20240313092346.1304889-1-zhengxu.zhang@unisoc.com>
> + request_max_size = queue_max_bytes(bdev_get_queue(bio->bi_bdev));
Besides all the coding style problems this is simply not how the bio
interface works. queue_max_bytes is a limit only available to the
splitting routines and not to the upper layers submitting I/O.
Please try to debug your scenarious a little more - just because a bio
get split off it should not just turn into a request of it's own,
but be merged with the next bio due to the plug. If that doesn't happen
we do have a problem somewhere.
next prev parent reply other threads:[~2024-03-13 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 9:23 [PATCH] block: Minimize the number of requests in Direct I/O when bio get pages Zhengxu Zhang
2024-03-13 21:49 ` Christoph Hellwig [this message]
2024-03-14 3:01 ` 张政旭
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfIfejdNTL8oassd@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=char.zzx@gmail.com \
--cc=hongyu.jin.cn@gmail.com \
--cc=hongyu.jin@unisoc.com \
--cc=ke.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=yunlongxing23@gmail.com \
--cc=zhengxu.zhang@unisoc.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox