From: Matthew Wilcox <willy@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Pankaj Raghav <p.raghav@samsung.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] brd: Remove use of page->index
Date: Fri, 15 Mar 2024 18:29:09 +0000 [thread overview]
Message-ID: <ZfSTdS_YMnQ_v-Wa@casper.infradead.org> (raw)
In-Reply-To: <ZfSTE4pEiKjKecbj@kbusch-mbp>
On Fri, Mar 15, 2024 at 12:27:31PM -0600, Keith Busch wrote:
> On Fri, Mar 15, 2024 at 12:23:23PM -0600, Keith Busch wrote:
> > This looks good. Unnecessary suggestion, but since you're already
> > changing these, might as well replace "sector" with "idx" here and skip
> > the duplicated shift in brd_lookup_page().
>
> Sorry forget that, all the other existing callers just want the
> sector_t.
Yeah, but I could just inline the xa_load(). Doesn't really seem
like a big deal to me, so I left it for now. Got to leave something for
other people to do ;-)
next prev parent reply other threads:[~2024-03-15 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 18:12 [PATCH] brd: Remove use of page->index Matthew Wilcox (Oracle)
2024-03-15 18:23 ` Keith Busch
2024-03-15 18:27 ` Keith Busch
2024-03-15 18:29 ` Matthew Wilcox [this message]
2024-03-15 18:27 ` Hannes Reinecke
2024-03-15 23:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfSTdS_YMnQ_v-Wa@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox