From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>, Ming Lei <ming.lei@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: block: fail unaligned bio from submit_bio_noacct()
Date: Thu, 21 Mar 2024 15:07:38 -0700 [thread overview]
Message-ID: <ZfyvqmslFn19vgdG@infradead.org> (raw)
In-Reply-To: <ea8a13c-ee40-47f9-a7be-17b84bd1f686@redhat.com>
On Thu, Mar 21, 2024 at 06:01:41PM +0100, Mikulas Patocka wrote:
> But then, the system would crash with the config option being 'n' and
> return an error with the config option being 'y' - which would be
> unfortunate.
>
> We could remove the check from the drivers and add it to the generic I/O
> path - this wouldn't add extra overhead.
Agreed. This is a pretty cheap check, and I'd rather have it all the
time instead of being duplicated in various drivers, just like we do
a lot of other sanity checking in submit_bio.
next prev parent reply other threads:[~2024-03-21 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 13:16 [PATCH] block: fail unaligned bio from submit_bio_noacct() Ming Lei
2024-03-21 15:14 ` Bart Van Assche
2024-03-21 15:18 ` Ming Lei
2024-03-21 15:43 ` Mike Snitzer
2024-03-21 17:01 ` Mikulas Patocka
2024-03-21 22:07 ` Christoph Hellwig [this message]
2024-03-22 2:08 ` Ming Lei
2024-03-22 2:39 ` Keith Busch
2024-03-24 8:02 ` Ming Lei
2024-03-22 10:16 ` Mikulas Patocka
2024-03-21 17:09 ` [PATCH] " Jens Axboe
2024-03-21 22:09 ` Christoph Hellwig
2024-03-21 22:50 ` Jens Axboe
2024-03-22 0:31 ` Christoph Hellwig
2024-03-22 1:21 ` Ming Lei
2024-03-21 22:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfyvqmslFn19vgdG@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).