From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH V2] block: fail unaligned bio from submit_bio_noacct()
Date: Mon, 25 Mar 2024 11:50:41 +0800 [thread overview]
Message-ID: <ZgD0kQCCQtu34q/D@fedora> (raw)
In-Reply-To: <ZgDrgTymGnW3KGuk@infradead.org>
On Sun, Mar 24, 2024 at 08:12:01PM -0700, Christoph Hellwig wrote:
> On Mon, Mar 25, 2024 at 11:03:25AM +0800, Ming Lei wrote:
> > Also only q->limits.logical_block_size is fetched for small BS IO
> > fast path, I think log(lbs) can be cached in request_queue for avoiding the
> > extra fetch of q.limits. Especially, it could be easier to do so
> > with your recent queue limit atomic update changes.
>
> So. One thing I've been thinking of for a while (and which Bart also
> mentioned) is tht queue_limits currently is a bit of a mess between
> the actual queue limits, and the gneidks configuration. The logical
> block size is firmly in the latter, and we should probably move it
lbs and pbs belong to disk, but some others may not be very obvious.
Strictly speaking elevator/blkcg belong to disk too, but still stay in
request_queue, :-)
Thanks,
Ming
next prev parent reply other threads:[~2024-03-25 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 13:37 [PATCH V2] block: fail unaligned bio from submit_bio_noacct() Ming Lei
2024-03-24 21:48 ` Mike Snitzer
2024-03-24 23:25 ` Christoph Hellwig
2024-03-25 3:03 ` Ming Lei
2024-03-25 3:12 ` Christoph Hellwig
2024-03-25 3:50 ` Ming Lei [this message]
2024-03-25 18:53 ` Keith Busch
2024-03-26 1:19 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgD0kQCCQtu34q/D@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).