From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
tj@kernel.org, axboe@kernel.dk, josef@toxicpanda.com,
shli@fb.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
Date: Tue, 26 Mar 2024 07:49:29 -0700 [thread overview]
Message-ID: <ZgLgedPipnZuyHCA@infradead.org> (raw)
In-Reply-To: <a4d8b56e-1814-4834-9d25-ef61ff6f1248@oracle.com>
On Tue, Mar 26, 2024 at 08:46:24AM +0000, John Garry wrote:
> On 26/03/2024 07:03, Christoph Hellwig wrote:
> > On Mon, Mar 25, 2024 at 12:19:05PM +0000, John Garry wrote:
> > > For when using gcc 8 and above, the following warnings can be seen when
> > > compiling blk-throttle.c with W=1:
> >
> > Why is this function even using these local buffers vs a sequence
> > of separate seq_printf calls that would get rid of these pointless
> > on-stack buffers?
>
> Currently a combo of snprintf and seq_printf is used, a strategy which seems
> to go as far back as 2ee867dcfa2ea (2015), when it was a much simpler print.
> All the other code in this area only uses seq_printf, so it seems that the
> author(s) prefer this way here.
>
> Here's how the current code could look (using only seq_printf):
That looks much better, thanks.
next prev parent reply other threads:[~2024-03-26 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 12:19 [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit() John Garry
2024-03-26 7:03 ` Christoph Hellwig
2024-03-26 8:46 ` John Garry
2024-03-26 14:49 ` Christoph Hellwig [this message]
2024-03-26 14:57 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgLgedPipnZuyHCA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox