From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Mike Snitzer <msnitzer@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <dlemoal@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Guangwu Zhang <guazhang@redhat.com>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c
Date: Wed, 17 Apr 2024 21:57:04 -0700 [thread overview]
Message-ID: <ZiCoIHFLAzCva2lU@infradead.org> (raw)
In-Reply-To: <546473fd-ca4b-3c64-349d-cc739088b748@redhat.com>
On Wed, Apr 17, 2024 at 08:00:22PM +0200, Mikulas Patocka wrote:
> > > +EXPORT_SYMBOL(wait_for_completion_long_io);
> >
> > Urgh, why is it a sane thing to circumvent the hang check timer?
>
> The block layer already does it - the bios can have arbitrary size, so
> waiting for them takes arbitrary time.
And as mentioned the last few times around, I think we want a task
state to say that task can sleep long or even forever and not propagate
this hack even further.
next prev parent reply other threads:[~2024-04-18 4:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:49 [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c Mikulas Patocka
2024-04-17 17:55 ` Peter Zijlstra
2024-04-17 18:00 ` Mikulas Patocka
2024-04-18 4:57 ` Christoph Hellwig [this message]
2024-04-18 14:30 ` Jens Axboe
2024-04-18 14:46 ` Christoph Hellwig
2024-04-18 15:09 ` Jens Axboe
2024-04-22 10:59 ` Peter Zijlstra
2024-04-23 12:36 ` Mikulas Patocka
2024-04-26 6:06 ` Christoph Hellwig
2024-04-22 10:54 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiCoIHFLAzCva2lU@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=guazhang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).