From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mike Snitzer <msnitzer@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Guangwu Zhang <guazhang@redhat.com>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c
Date: Thu, 18 Apr 2024 07:46:06 -0700 [thread overview]
Message-ID: <ZiEyLvL6Pq_RB-Eh@infradead.org> (raw)
In-Reply-To: <5f3d434b-e05c-445f-bee5-2bb1f11a5946@kernel.dk>
On Thu, Apr 18, 2024 at 08:30:14AM -0600, Jens Axboe wrote:
> It certainly is a hack/work-around, but unless there are a lot more that
> should be using something like this, I don't think adding extra core
> complexity in terms of a special task state (or per-task flag, at least
> that would be easier) is really warranted.
Basically any kernel thread doing on-demand work has the same problem.
It just has an easier workaround hack, as the kernel threads can simply
claim to do an interruptible sleep to not trigger the softlockup
warnings.
next prev parent reply other threads:[~2024-04-18 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:49 [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c Mikulas Patocka
2024-04-17 17:55 ` Peter Zijlstra
2024-04-17 18:00 ` Mikulas Patocka
2024-04-18 4:57 ` Christoph Hellwig
2024-04-18 14:30 ` Jens Axboe
2024-04-18 14:46 ` Christoph Hellwig [this message]
2024-04-18 15:09 ` Jens Axboe
2024-04-22 10:59 ` Peter Zijlstra
2024-04-23 12:36 ` Mikulas Patocka
2024-04-26 6:06 ` Christoph Hellwig
2024-04-22 10:54 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEyLvL6Pq_RB-Eh@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=guazhang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).