[PATCH] bio: Export bio_add_folio_nofail to modules

[PATCH] bio: Export bio_add_folio_nofail to modules

[Matthew Wilcox (Oracle)]

Several modules use __bio_add_page() today and may need to be converted
to bio_add_folio_nofail().

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 block/bio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/bio.c b/block/bio.c
index 38baedb39c6f..3f3977c69997 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1125,6 +1125,7 @@ void bio_add_folio_nofail(struct bio *bio, struct folio *folio, size_t len,
 	WARN_ON_ONCE(off > UINT_MAX);
 	__bio_add_page(bio, &folio->page, len, off);
 }
+EXPORT_SYMBOL_GPL(bio_add_folio_nofail);
 
 /**
  * bio_add_folio - Attempt to add part of a folio to a bio.
-- 
2.43.0

Re: [PATCH] bio: Export bio_add_folio_nofail to modules

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Re: [PATCH] bio: Export bio_add_folio_nofail to modules

[Jens Axboe]

On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote:
> Several modules use __bio_add_page() today and may need to be converted
> to bio_add_folio_nofail().

Confused, we don't have any modular users of this. A change like this
should be submitted with a conversion.

-- 
Jens Axboe

Re: [PATCH] bio: Export bio_add_folio_nofail to modules

[Matthew Wilcox]

On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote:
> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote:
> > Several modules use __bio_add_page() today and may need to be converted
> > to bio_add_folio_nofail().
> 
> Confused, we don't have any modular users of this. A change like this
> should be submitted with a conversion.

Thank you for reinforcing my point.

https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/

Can I have an Acked-by so David can take it through the btrfs tree?

Re: [PATCH] bio: Export bio_add_folio_nofail to modules

[Jens Axboe]

On 4/26/24 8:02 AM, Matthew Wilcox wrote:
> On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote:
>> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote:
>>> Several modules use __bio_add_page() today and may need to be converted
>>> to bio_add_folio_nofail().
>>
>> Confused, we don't have any modular users of this. A change like this
>> should be submitted with a conversion.
> 
> Thank you for reinforcing my point.
> 
> https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/
> 
> Can I have an Acked-by so David can take it through the btrfs tree?

Yeah that's fine, makes more sense now than the standalone one:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe

Re: [PATCH] bio: Export bio_add_folio_nofail to modules

[David Sterba]

On Fri, Apr 26, 2024 at 08:03:56AM -0600, Jens Axboe wrote:
> On 4/26/24 8:02 AM, Matthew Wilcox wrote:
> > On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote:
> >> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote:
> >>> Several modules use __bio_add_page() today and may need to be converted
> >>> to bio_add_folio_nofail().
> >>
> >> Confused, we don't have any modular users of this. A change like this
> >> should be submitted with a conversion.
> > 
> > Thank you for reinforcing my point.
> > 
> > https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/
> > 
> > Can I have an Acked-by so David can take it through the btrfs tree?
> 
> Yeah that's fine, makes more sense now than the standalone one:
> 
> Reviewed-by: Jens Axboe <axboe@kernel.dk>

Thanks, I'll add it to Matthew's series in my patch queue and it'll
appear in linux-next soon.