From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 832E37E8 for ; Mon, 3 Jun 2024 00:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717376056; cv=none; b=UIDQsCf0z4DA5ychlvHLTDW+6gMCl/C9EUAX9xtwMbCuEEVZx68sve0pmfRMBM12bS3fkOz4u0+yIxY8sUfF2zgV/21KlDxQoZtPMYULn4x08r3h3jULAyKddxEmTZRBRM9/Qut8VE6F0G0Eg8FC+6xtIi7Z1kx1UZ9i7AzcFwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717376056; c=relaxed/simple; bh=FCG0IEbOfT/bHhxbTtejsIy3REUx0zfjYOoOQ1qBhKQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mcExhYVSmidfyn/mTXrb2OHHEL59kLAhHMMKHIaWmg+DySlR+owB6Ng09YViHszS9391wAjquIE1n2H8dAhCjQ1VpDmo5KWDezY5FrrMedc+1+Ysagup7YROjdAqyW5YnasOixaEV0eyUe2qQ4y7RH2Mik1v1GboBjGq/HEXvM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TNI9Akv3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TNI9Akv3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717376051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JwTjl/fChud/3QoHHQ7fbqf2HYYxzvAlq+JNY96sgcY=; b=TNI9Akv3x1AvyvZLy9OXSgOE5WH505/A/KgW+by1CsYFjuCgR8mKFNcLDSHcLMaZJ/YpYe iS/s5yOCSR+nXFqtUXPWTTTXqtz2YEcLmGFc2ahngysDPMEnUyeXBT1al9R0uFqIkk9adZ 0OzYt5VOrQzZ+boH2Jm8WTh6tcRN6to= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-EwEXPhcON8iH50r5nD5WZg-1; Sun, 02 Jun 2024 20:54:05 -0400 X-MC-Unique: EwEXPhcON8iH50r5nD5WZg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C115D1C05129; Mon, 3 Jun 2024 00:54:04 +0000 (UTC) Received: from fedora (unknown [10.72.116.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CAF7440D182; Mon, 3 Jun 2024 00:54:01 +0000 (UTC) Date: Mon, 3 Jun 2024 08:53:57 +0800 From: Ming Lei To: Jeff Johnson Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro Message-ID: References: <20240602-md-block-ublk_drv-v1-1-995474cafff0@quicinc.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240602-md-block-ublk_drv-v1-1-995474cafff0@quicinc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson > --- > drivers/block/ublk_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > index 4e159948c912..59916895ee2e 100644 > --- a/drivers/block/ublk_drv.c > +++ b/drivers/block/ublk_drv.c > @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644); > MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)"); > > MODULE_AUTHOR("Ming Lei "); > +MODULE_DESCRIPTION("Userspace block device"); > MODULE_LICENSE("GPL"); Reviewed-by: Ming Lei Thanks, Ming