[PATCH blktests] README: add dependent command descriptions

[PATCH blktests] README: add dependent command descriptions

[Shin'ichiro Kawasaki]

Even though many test cases assume the availability of the systemd-udev
service and the udevadm command, this dependency is not described. Add
it to the dependency list. Also add optional dependencies to other
commands: mkfs.f2fs, mkfs.btrfs, nvme, nbd-client and nbd-server.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 README.md | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 09fbb1e..55227d9 100644
--- a/README.md
+++ b/README.md
@@ -19,12 +19,15 @@ The dependencies are minimal, but make sure you have them installed:
 - fio
 - gcc
 - make
+- systemd-udev (udevadm)
 
 Some tests require the following:
 
-- e2fsprogs and xfsprogs
+- e2fsprogs, xfsprogs, f2fs-tools and btrfs-progs
+- nvme-cli
 - multipath-tools (Debian, openSUSE, Arch Linux) or device-mapper-multipath
   (Fedora)
+- nbd-client and nbd-server (Debian) or nbd (Fedora, openSUSE, Arch Linux)
 - dmsetup (Debian) or device-mapper (Fedora, openSUSE, Arch Linux)
 - rublk (`cargo install --version=^0.1 rublk`) for ublk test
 
-- 
2.45.0

Re: [PATCH blktests] README: add dependent command descriptions

[Chaitanya Kulkarni]

On 6/3/24 17:42, Shin'ichiro Kawasaki wrote:
> Even though many test cases assume the availability of the systemd-udev
> service and the udevadm command, this dependency is not described. Add
> it to the dependency list. Also add optional dependencies to other
> commands: mkfs.f2fs, mkfs.btrfs, nvme, nbd-client and nbd-server.
>
> Signed-off-by: Shin'ichiro Kawasaki<shinichiro.kawasaki@wdc.com>

Thanks a lot, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH blktests] README: add dependent command descriptions

[Christoph Hellwig]

On Tue, Jun 04, 2024 at 09:42:41AM +0900, Shin'ichiro Kawasaki wrote:
> Even though many test cases assume the availability of the systemd-udev
> service and the udevadm command, this dependency is not described. Add
> it to the dependency list. Also add optional dependencies to other
> commands: mkfs.f2fs, mkfs.btrfs, nvme, nbd-client and nbd-server.

Should something check that they are present and warn if not?

Re: [PATCH blktests] README: add dependent command descriptions

[Shinichiro Kawasaki]

On Jun 03, 2024 / 21:46, Christoph Hellwig wrote:
> On Tue, Jun 04, 2024 at 09:42:41AM +0900, Shin'ichiro Kawasaki wrote:
> > Even though many test cases assume the availability of the systemd-udev
> > service and the udevadm command, this dependency is not described. Add
> > it to the dependency list. Also add optional dependencies to other
> > commands: mkfs.f2fs, mkfs.btrfs, nvme, nbd-client and nbd-server.
> 
> Should something check that they are present and warn if not?

Yes, that will be helpful. Will create another patch for it.

Re: [PATCH blktests] README: add dependent command descriptions

[Shinichiro Kawasaki]

On Jun 04, 2024 / 09:42, Shin'ichiro Kawasaki wrote:
> Even though many test cases assume the availability of the systemd-udev
> service and the udevadm command, this dependency is not described. Add
> it to the dependency list. Also add optional dependencies to other
> commands: mkfs.f2fs, mkfs.btrfs, nvme, nbd-client and nbd-server.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

FYI, I've applied the patch. A follow-up patch is posted per review comment:

    https://lore.kernel.org/linux-block/20240607045246.248590-1-shinichiro.kawasaki@wdc.com/