From: Christoph Hellwig <hch@infradead.org>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] loop: Disable fallocate() zero and discard if not supported
Date: Mon, 10 Jun 2024 07:14:42 -0700 [thread overview]
Message-ID: <ZmcKUgJXc9MOLvqj@infradead.org> (raw)
In-Reply-To: <ZmcKA3zHsOYlyaiq@yuki>
On Mon, Jun 10, 2024 at 04:13:23PM +0200, Cyril Hrubis wrote:
> Do we need noinline attribute for the function as well or unlikely() in
> the if condition?
unlikely sounds like the right thing here.
> > (and maybe one day we figure out a way for the file system to
> > advertise what fallocate modes it actually supports..)
>
> One of my ideas was to try fallocate() with zero size in the
> loop_reconfigure_limits() to see if we get EOPNOTSUPP but for that to
> work we would have to make sure that we do not bail early on zero size
> in the vfs layer...
And the VFS layer doesn't know, it has to go all the way into the
file system..
prev parent reply other threads:[~2024-06-10 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 9:15 [PATCH] loop: Disable fallocate() zero and discard if not supported Cyril Hrubis
2024-06-07 15:06 ` Petr Vorel
2024-06-08 5:42 ` Christoph Hellwig
2024-06-10 2:47 ` Chaitanya Kulkarni
2024-06-10 14:13 ` Cyril Hrubis
2024-06-10 14:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmcKUgJXc9MOLvqj@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chrubis@suse.cz \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).