From: Tejun Heo <tj@kernel.org>
To: Li Lingfeng <lilingfeng@huaweicloud.com>
Cc: josef@toxicpanda.com, hch@lst.de, axboe@kernel.dk,
mkoutny@suse.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yangerkun@huawei.com, yukuai1@huaweicloud.com,
houtao1@huawei.com, yi.zhang@huawei.com, lilingfeng3@huawei.com
Subject: Re: [PATCH v2] block: flush all throttled bios when deleting the cgroup
Date: Thu, 27 Jun 2024 10:43:15 -1000 [thread overview]
Message-ID: <Zn3O47DUoLliwbWm@slm.duckdns.org> (raw)
In-Reply-To: <20240627142606.3709394-1-lilingfeng@huaweicloud.com>
Hello, Li.
On Thu, Jun 27, 2024 at 10:26:06PM +0800, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@huawei.com>
>
> When a process migrates to another cgroup and the original cgroup is deleted,
> the restrictions of throttled bios cannot be removed. If the restrictions
> are set too low, it will take a long time to complete these bios.
>
> Refer to the process of deleting a disk to remove the restrictions and
> issue bios when deleting the cgroup.
>
> This makes difference on the behavior of throttled bios:
> Before: the limit of the throttled bios can't be changed and the bios will
> complete under this limit;
> Now: the limit will be canceled and the throttled bios will be flushed
> immediately.
I'm not necessarily against this but the description doesn't explain why
this is better either. Can you please detail why this behavior is better?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-06-27 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 14:26 [PATCH v2] block: flush all throttled bios when deleting the cgroup Li Lingfeng
2024-06-27 20:43 ` Tejun Heo [this message]
2024-06-28 2:04 ` Li Lingfeng
2024-06-28 3:32 ` Yu Kuai
2024-07-02 14:25 ` Michal Koutný
2024-07-06 7:21 ` Li Lingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn3O47DUoLliwbWm@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=josef@toxicpanda.com \
--cc=lilingfeng3@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox