From: Christoph Hellwig <hch@infradead.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Felix Fietkau" <nbd@nbd.name>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Dave Chinner" <dchinner@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Christian Brauner" <brauner@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Li Lingfeng" <lilingfeng3@huawei.com>,
"Christian Heusel" <christian@heusel.eu>,
"Min Li" <min15.li@samsung.com>,
"Avri Altman" <avri.altman@wdc.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Hannes Reinecke" <hare@suse.de>,
"Mikko Rapeli" <mikko.rapeli@linaro.org>,
"Yeqi Fu" <asuk4.q@gmail.com>,
"Victor Shih" <victor.shih@genesyslogic.com.tw>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Li Zhijian" <lizhijian@fujitsu.com>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v4 2/4] block: partitions: populate fwnode
Date: Thu, 27 Jun 2024 21:44:28 -0700 [thread overview]
Message-ID: <Zn4_rMJVm6cpIEZV@infradead.org> (raw)
In-Reply-To: <6acc459a392d562abc58f7e55c6f04dba8073257.1719520771.git.daniel@makrotopia.org>
On Thu, Jun 27, 2024 at 09:50:39PM +0100, Daniel Golle wrote:
> + /*
> + * In case 'uuid' is defined in the partitions firmware node require
> + * partition meta info being present and the specified uuid to match.
> + */
Overly long lines, which is really annyoing for block comments.
> + got_uuid = !fwnode_property_read_string(fw_part, "uuid", &uuid);
> + if (got_uuid && (!bdev->bd_meta_info ||
> + !part_meta_match(uuid, bdev->bd_meta_info->uuid,
> + PARTITION_META_INFO_UUIDLTH)))
Can we please not use the crazy part_meta stuff for anything new?
We should never have merge it, and right now it is at least isolated
to the boot time root dev_t partsing, and I'd really prefer to keep it
in that corner.
next prev parent reply other threads:[~2024-06-28 4:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 20:49 [PATCH v4 0/4] block: preparations for NVMEM provider Daniel Golle
2024-06-27 20:50 ` [PATCH v4 1/4] dt-bindings: block: add basic bindings for block devices Daniel Golle
2024-06-27 20:50 ` [PATCH v4 2/4] block: partitions: populate fwnode Daniel Golle
2024-06-28 4:44 ` Christoph Hellwig [this message]
2024-06-28 12:16 ` Daniel Golle
2024-06-28 12:41 ` Christoph Hellwig
2024-06-27 20:50 ` [PATCH v4 3/4] block: add support for notifications Daniel Golle
2024-06-28 4:45 ` Christoph Hellwig
2024-06-28 12:23 ` Daniel Golle
2024-06-28 12:50 ` Christoph Hellwig
2024-06-28 14:00 ` Daniel Golle
2024-07-01 5:54 ` Christoph Hellwig
2024-06-27 20:51 ` [PATCH v4 4/4] block: add new genhd flag GENHD_FL_NVMEM Daniel Golle
2024-06-27 22:15 ` [PATCH v4 0/4] block: preparations for NVMEM provider Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn4_rMJVm6cpIEZV@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=asuk4.q@gmail.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=dchinner@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.de \
--cc=hauke@hauke-m.de \
--cc=jack@suse.cz \
--cc=krzk+dt@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lizhijian@fujitsu.com \
--cc=mikko.rapeli@linaro.org \
--cc=min15.li@samsung.com \
--cc=nbd@nbd.name \
--cc=ricardo@marliere.net \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).