From: Matthew Wilcox <willy@infradead.org>
To: Kundan Kumar <kundan.kumar@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
linux-block@vger.kernel.org, joshi.k@samsung.com,
mcgrof@kernel.org, anuj20.g@samsung.com, nj.shetty@samsung.com,
c.gameti@samsung.com, gost.dev@samsung.com
Subject: Re: [PATCH v5 3/3] block: unpin user pages belonging to a folio
Date: Thu, 20 Jun 2024 04:51:16 +0100 [thread overview]
Message-ID: <ZnOnNAdDl_jM1k8G@casper.infradead.org> (raw)
In-Reply-To: <20240619023420.34527-4-kundan.kumar@samsung.com>
On Wed, Jun 19, 2024 at 08:04:20AM +0530, Kundan Kumar wrote:
> if (mark_dirty) {
> folio_lock(fi.folio);
> folio_mark_dirty(fi.folio);
> folio_unlock(fi.folio);
> }
> - page = folio_page(fi.folio, fi.offset / PAGE_SIZE);
> - nr_pages = (fi.offset + fi.length - 1) / PAGE_SIZE -
> - fi.offset / PAGE_SIZE + 1;
> - do {
> - bio_release_page(bio, page++);
> - } while (--nr_pages != 0);
> + bio_release_folio(bio, fi.folio, 1);
... no, call bio_release_folio(bio, fi.folio, nr_pages);
> @@ -1372,6 +1364,9 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
> } else
> bio_iov_add_folio(bio, folio, len, folio_offset);
>
> + if (num_pages > 1)
> + bio_release_folio(bio, folio, num_pages - 1);
> +
... and drop this hunk.
prev parent reply other threads:[~2024-06-20 3:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240619024142epcas5p22b2e0f83e526fc74fda62a4837bed544@epcas5p2.samsung.com>
2024-06-19 2:34 ` [PATCH v5 0/3] block: add larger order folio instead of pages Kundan Kumar
2024-06-19 2:34 ` [PATCH v5 1/3] block: Added folio-lized version of bio_add_hw_page() Kundan Kumar
2024-06-20 3:47 ` Matthew Wilcox
2024-06-19 2:34 ` [PATCH v5 2/3] block: add folio awareness instead of looping through pages Kundan Kumar
2024-06-19 7:47 ` Hannes Reinecke
2024-06-20 4:48 ` Kundan Kumar
2024-06-20 7:21 ` Hannes Reinecke
2024-06-19 2:34 ` [PATCH v5 3/3] block: unpin user pages belonging to a folio Kundan Kumar
2024-06-20 3:51 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnOnNAdDl_jM1k8G@casper.infradead.org \
--to=willy@infradead.org \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=c.gameti@samsung.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kundan.kumar@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox