From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jgross@suse.com, marmarek@invisiblethingslab.com,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
Rusty Bird <rustybird@net-c.com>
Subject: Re: [PATCH] xen-blkfront: fix sector_size propagation to the block layer
Date: Tue, 25 Jun 2024 10:45:55 +0200 [thread overview]
Message-ID: <ZnqDwwXgwDlggHgH@macbook> (raw)
In-Reply-To: <20240625055238.7934-1-hch@lst.de>
On Tue, Jun 25, 2024 at 07:52:38AM +0200, Christoph Hellwig wrote:
> Ensure that info->sector_size and info->physical_sector_size are set
> before the call to blkif_set_queue_limits by doing away with the
> local variables and arguments that propagate them.
>
> Thanks to Marek Marczykowski-Górecki and Jürgen Groß for root causing
> the issue.
>
> Fixes: ba3f67c11638 ("xen-blkfront: atomically update queue limits")
> Reported-by: Rusty Bird <rustybird@net-c.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks for debugging this.
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
next prev parent reply other threads:[~2024-06-25 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 5:52 [PATCH] xen-blkfront: fix sector_size propagation to the block layer Christoph Hellwig
2024-06-25 8:45 ` Roger Pau Monné [this message]
2024-07-02 7:33 ` Juergen Gross
2024-07-02 14:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnqDwwXgwDlggHgH@macbook \
--to=roger.pau@citrix.com \
--cc=hch@lst.de \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=rustybird@net-c.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox