From: Uday Shankar <ushankar@purestorage.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/4] ublk: check recovery flags for validity
Date: Tue, 23 Jul 2024 13:32:47 -0600 [thread overview]
Message-ID: <ZqAFX9QorUzcHMK/@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <ZnDqKFtBULaddzov@fedora>
On Tue, Jun 18, 2024 at 10:00:08AM +0800, Ming Lei wrote:
> > + /* forbid nonsense combinations of recovery flags */
> > + switch (info.flags & UBLK_F_ALL_RECOVERY_FLAGS) {
> > + case 0:
> > + case UBLK_F_USER_RECOVERY:
> > + case (UBLK_F_USER_RECOVERY | UBLK_F_USER_RECOVERY_REISSUE):
> > + break;
> > + default:
> > + pr_warn("%s: invalid recovery flags %llx\n", __func__,
> > + info.flags & UBLK_F_ALL_RECOVERY_FLAGS);
> > + return -EINVAL;
> > + }
> > +
>
> It could be cleaner and more readable to check the fail condition only:
>
> if ((info.flags & UBLK_F_USER_RECOVERY_REISSUE) &&
> !(info.flags & UBLK_F_USER_RECOVERY)) {
> ...
> }
Will do. But note that in patch 4 this check gets more complex so we may
change it back to a switch statement.
next prev parent reply other threads:[~2024-07-23 19:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 19:44 [PATCH 0/4] ublk: support device recovery without I/O queueing Uday Shankar
2024-06-17 19:44 ` [PATCH 1/4] ublk: check recovery flags for validity Uday Shankar
2024-06-18 2:00 ` Ming Lei
2024-07-23 19:32 ` Uday Shankar [this message]
2024-06-17 19:44 ` [PATCH 2/4] ublk: refactor recovery configuration flag helpers Uday Shankar
2024-06-18 2:11 ` Ming Lei
2024-06-26 17:22 ` Uday Shankar
2024-06-27 1:17 ` Ming Lei
2024-06-27 17:09 ` Uday Shankar
2024-06-30 13:56 ` Ming Lei
2024-07-01 21:02 ` Uday Shankar
2024-07-02 4:07 ` Ming Lei
2024-07-02 11:09 ` Ming Lei
2024-09-17 0:26 ` Uday Shankar
2024-06-17 19:44 ` [PATCH 3/4] ublk: merge stop_work and quiesce_work Uday Shankar
2024-07-02 13:31 ` Ming Lei
2024-06-17 19:44 ` [PATCH 4/4] ublk: support device recovery without I/O queueing Uday Shankar
2024-07-02 13:46 ` Ming Lei
2024-09-17 0:29 ` Uday Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqAFX9QorUzcHMK/@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).