From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
axboe@kernel.dk, martin.petersen@oracle.com,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, sagi@grimberg.me
Subject: Re: [PATCHv5 4/9] blk-integrity: consider entire bio list for merging
Date: Mon, 16 Sep 2024 10:40:50 +0200 [thread overview]
Message-ID: <ZufvEhr-UO_BGm6_@kbusch-mbp> (raw)
In-Reply-To: <20240916064412.GA15929@lst.de>
On Mon, Sep 16, 2024 at 08:44:13AM +0200, Christoph Hellwig wrote:
> The wrong thing primarily is the above commit log. The code change
> itself is correct, but we'd be better off killing the iteration over
> the bio chain as well to make the code less confusing.
Okay, gotcha. I mentioned the existing code is a no op in "most cases"
but it should just be "always". Maybe a sanity check with a WARN here is
appropriate too.
BTW, sorry for mislabeling the tags. The patch numbers changed a few
times in this series, and I pasted reviews from the a different message.
next prev parent reply other threads:[~2024-09-16 8:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 18:28 [PATCHv5 0/9] block integrity merging and counting Keith Busch
2024-09-13 18:28 ` [PATCHv5 1/9] blk-mq: unconditional nr_integrity_segments Keith Busch
2024-09-13 18:28 ` [PATCHv5 2/9] blk-mq: set the nr_integrity_segments from bio Keith Busch
2024-09-13 18:28 ` [PATCHv5 3/9] blk-integrity: properly account for segments Keith Busch
2024-09-13 18:28 ` [PATCHv5 4/9] blk-integrity: consider entire bio list for merging Keith Busch
2024-09-14 7:30 ` Christoph Hellwig
2024-09-14 16:51 ` Keith Busch
2024-09-16 6:44 ` Christoph Hellwig
2024-09-16 8:40 ` Keith Busch [this message]
2024-09-13 18:28 ` [PATCHv5 5/9] block: provide a request helper for user integrity segments Keith Busch
2024-09-13 18:28 ` [PATCHv5 6/9] scsi: use request to get " Keith Busch
2024-09-13 18:28 ` [PATCHv5 7/9] nvme-rdma: " Keith Busch
2024-09-13 18:28 ` [PATCHv5 8/9] block: unexport blk_rq_count_integrity_sg Keith Busch
2024-09-13 18:28 ` [PATCHv5 9/9] blk-integrity: improved sg segment mapping Keith Busch
2024-09-13 18:37 ` [PATCHv5 0/9] block integrity merging and counting Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZufvEhr-UO_BGm6_@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox