From: Christoph Hellwig <hch@infradead.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
INAGAKI Hiroshi <musashino.open@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Ming Lei <ming.lei@redhat.com>,
Jan Kara <jack@suse.cz>, Li Lingfeng <lilingfeng3@huawei.com>,
Christian Heusel <christian@heusel.eu>,
Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mikko Rapeli <mikko.rapeli@linaro.org>,
Riyan Dhiman <riyandhiman14@gmail.com>,
Jorge Ramirez-Ortiz <jorge@foundries.io>,
Dominique Martinet <dominique.martinet@atmark-techno.com>,
Jens Wiklander <jens.wiklander@linaro.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Li Zhijian <lizhijian@fujitsu.com>,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, Lorenzo Bianconi <lorenzo@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
upstream@airoha.com
Subject: Re: [PATCH v5 5/6] block: add support for partition table defined in OF
Date: Wed, 2 Oct 2024 01:43:14 -0700 [thread overview]
Message-ID: <Zv0HotHuCGDpmFp7@infradead.org> (raw)
In-Reply-To: <20241001221931.9309-6-ansuelsmth@gmail.com>
On Wed, Oct 02, 2024 at 12:18:57AM +0200, Christian Marangi wrote:
> +static int validate_of_partition(struct device_node *np, int slot)
> +{
> + int a_cells, s_cells;
> + const __be32 *reg;
> + u64 offset, size;
> + int len;
> +
> + reg = of_get_property(np, "reg", &len);
> +
> + a_cells = of_n_addr_cells(np);
> + s_cells = of_n_size_cells(np);
Just personal preference, but I find code easier to read if variables
are initialized at declaration time whenever possible:
const __be32 *reg = of_get_property(np, "reg", &len);
int a_cells = of_n_addr_cells(np);
int s_cells = of_n_size_cells(np);
(same for a few other functions below)
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-02 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 22:18 [PATCH v5 0/6] block: partition table OF support Christian Marangi
2024-10-01 22:18 ` [PATCH v5 1/6] block: add support for defining read-only partitions Christian Marangi
2024-10-01 22:18 ` [PATCH v5 2/6] docs: block: Document support for read-only partition in cmdline part Christian Marangi
2024-10-01 22:18 ` [PATCH v5 3/6] block: introduce device_add_of_disk() Christian Marangi
2024-10-02 8:40 ` Christoph Hellwig
2024-10-02 8:46 ` Christian Marangi
2024-10-02 9:04 ` Christoph Hellwig
2024-10-01 22:18 ` [PATCH v5 4/6] mmc: block: attach partitions fwnode if found in mmc-card Christian Marangi
2024-10-02 13:59 ` Linus Walleij
2024-10-01 22:18 ` [PATCH v5 5/6] block: add support for partition table defined in OF Christian Marangi
2024-10-02 8:43 ` Christoph Hellwig [this message]
2024-10-01 22:18 ` [PATCH v5 6/6] dt-bindings: mmc: Document support for partition table in mmc-card Christian Marangi
2024-10-02 14:01 ` Linus Walleij
2024-10-02 21:07 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv0HotHuCGDpmFp7@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=ansuelsmth@gmail.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=dominique.martinet@atmark-techno.com \
--cc=jack@suse.cz \
--cc=jens.wiklander@linaro.org \
--cc=jorge@foundries.io \
--cc=krzk+dt@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=lorenzo@kernel.org \
--cc=mikko.rapeli@linaro.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=musashino.open@gmail.com \
--cc=riyandhiman14@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=upstream@airoha.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).