From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: remove redundant passthrough check in blk_mq_need_time_stamp()
Date: Wed, 2 Oct 2024 14:14:10 -0600 [thread overview]
Message-ID: <Zv2pkuK-AWKP75GD@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <2aae722e-e815-4fe9-8321-86b062f517b3@kernel.dk>
On Wed, Oct 02, 2024 at 02:11:07PM -0600, Jens Axboe wrote:
> Simply checking the rq_flags is enough to determine if accounting is
> being done for this request.
Yep, rq_flags do not get set if request is a passthrough, so checking
both is redundant.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2024-10-02 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 20:11 [PATCH] block: remove redundant passthrough check in blk_mq_need_time_stamp() Jens Axboe
2024-10-02 20:14 ` Keith Busch [this message]
2024-10-03 8:20 ` Anuj gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv2pkuK-AWKP75GD@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox