From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Waiman Long <longman@redhat.com>, Yu Kuai <yukuai3@huawei.com>,
Josef Bacik <josef@toxicpanda.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] blk_iocost: remove some duplicate irq disable/enables
Date: Thu, 3 Oct 2024 11:30:44 -1000 [thread overview]
Message-ID: <Zv8NBM4mOVoMoBQS@slm.duckdns.org> (raw)
In-Reply-To: <Zv8LAaeuJQkvscWF@slm.duckdns.org>
On Thu, Oct 03, 2024 at 11:22:09AM -1000, Tejun Heo wrote:
> Yeah, that should be spin_lock_irq() for consistency but at the same time it
> doesn't look like anything is actually grabbing that lock (or blkcg->lock
> nesting outside of it) from an IRQ context, so no actual deadlock scenario
> exists and lockdep doesn't trigger.
Oh, wait, it's not that. blkg_conf_prep() implies queue_lock, so the IRQ is
disabled around it and adding _irq will trigger lockdep.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-10-03 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 10:47 [PATCH v2] blk_iocost: remove some duplicate irq disable/enables Dan Carpenter
2024-10-02 13:17 ` Jens Axboe
2024-10-02 17:49 ` Waiman Long
2024-10-02 18:10 ` Dan Carpenter
2024-10-02 18:40 ` Waiman Long
2024-10-03 12:03 ` Dan Carpenter
2024-10-03 13:21 ` Jens Axboe
2024-10-03 14:31 ` Dan Carpenter
2024-10-03 14:38 ` Jens Axboe
2024-10-03 15:49 ` Waiman Long
2024-10-03 16:24 ` Jens Axboe
2024-10-03 21:22 ` Tejun Heo
2024-10-03 21:30 ` Tejun Heo [this message]
2024-10-03 22:06 ` Jens Axboe
2024-10-04 10:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv8NBM4mOVoMoBQS@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox